From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGrA-0001oL-2m for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:35:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlGr3-0005Lp-NN for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:35:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlGr3-0005Lh-8r for qemu-devel@nongnu.org; Mon, 03 Nov 2014 07:35:29 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA3CZSDo018710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 3 Nov 2014 07:35:28 -0500 Message-ID: <5457768C.6060400@redhat.com> Date: Mon, 03 Nov 2014 13:35:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414785819-26209-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1414785819-26209-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com On 31/10/2014 21:03, John Snow wrote: > - Adjust the prepare_buf() callback to return, simply, the number > of bytes it was able to prepare, or -1 on error. This resolves > an ambiguity around the nature of its return code meaning > "no sectors" or "no bytes" which led to bad error pathways. Much nicer! Sounds obvious, but hindsight is 20/20... > John Snow (3): > ide: repair PIO transfers for cases where nsector > 1 > ahci: unify sglist preparation > ide: Correct handling of malformed/short PRDTs > > hw/ide/ahci.c | 33 ++++++++++++++++++++++++++------- > hw/ide/core.c | 14 ++++++++++++-- > hw/ide/internal.h | 13 +++++++------ > hw/ide/macio.c | 7 ++++++- > hw/ide/pci.c | 27 +++++++++++++++++++++------ > 5 files changed, 72 insertions(+), 22 deletions(-) > Reviewed-by: Paolo Bonzini Paolo