From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJ0J-0004He-5w for qemu-devel@nongnu.org; Mon, 03 Nov 2014 09:53:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJ0D-0006a6-Jq for qemu-devel@nongnu.org; Mon, 03 Nov 2014 09:53:11 -0500 Message-ID: <545796CE.2010706@suse.de> Date: Mon, 03 Nov 2014 15:53:02 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1414405406-653-1-git-send-email-clg@fr.ibm.com> In-Reply-To: <1414405406-653-1-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q8OpZHJpYyBMZSBHb2F0ZXI=?= Cc: aik@ozlabs.ru, paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 27.10.14 11:23, C=C3=A9dric Le Goater wrote: > Currently, when the page tables are saved, the kvm_get_htab_header stru= cts=20 > and the ptes are assumed being big endian and dumped as a indistinct bl= ob=20 > in the statefile. This is no longer true when the host is little endian= =20 > and this breaks restoration. >=20 > This patch unfolds the kvmppc_save_htab routine to write explicitly the= =20 > kvm_get_htab_header structs in big endian. The ptes are left untouched. >=20 > Signed-off-by: C=C3=A9dric Le Goater > Cc: paulus@samba.org > Cc: aik@ozlabs.ru > Cc: gkurz@linux.vnet.ibm.com LGTM :) Alex