* Re: [Qemu-devel] [PATCH] target-ppc: simplify AES emulation
[not found] <1414427152-8715-1-git-send-email-aurelien@aurel32.net>
@ 2014-11-03 14:55 ` Alexander Graf
0 siblings, 0 replies; only message in thread
From: Alexander Graf @ 2014-11-03 14:55 UTC (permalink / raw)
To: Aurelien Jarno, qemu-ppc; +Cc: Paolo Bonzini, qemu-devel
On 27.10.14 17:25, Aurelien Jarno wrote:
> This patch simplifies the AES code, by directly accessing the newly added
> S-Box, InvS-Box tables instead of recreating them by using the AES_Te and
> AES_Td tables.
>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Thanks, applied to ppc-next. It's great to see you back Aurelien!
Alex
PS: Please CC qemu-devel on patches, so that non-ppc interested people
have the chance to review as well ;).
> ---
> target-ppc/int_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Note: This has been requested by Paolo Bonzini, but I have no way to
> test it, so it is only compile tested.
>
> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
> index 713d777..e67a5ee 100644
> --- a/target-ppc/int_helper.c
> +++ b/target-ppc/int_helper.c
> @@ -2352,7 +2352,7 @@ void helper_vcipherlast(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
> int i;
>
> VECTOR_FOR_INORDER_I(i, u8) {
> - r->AVRB(i) = b->AVRB(i) ^ (AES_Te4[a->AVRB(AES_shifts[i])] & 0xFF);
> + r->AVRB(i) = b->AVRB(i) ^ (AES_sbox[a->AVRB(AES_shifts[i])]);
> }
> }
>
> @@ -2381,7 +2381,7 @@ void helper_vncipherlast(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
> int i;
>
> VECTOR_FOR_INORDER_I(i, u8) {
> - r->AVRB(i) = b->AVRB(i) ^ (AES_Td4[a->AVRB(AES_ishifts[i])] & 0xFF);
> + r->AVRB(i) = b->AVRB(i) ^ (AES_isbox[a->AVRB(AES_ishifts[i])]);
> }
> }
>
>
^ permalink raw reply [flat|nested] only message in thread