From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1XlJ4u-00025y-71
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 09:58:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1XlJ4l-0008U9-St
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 09:57:56 -0500
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:47612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1XlJ4l-0008Td-It
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 09:57:47 -0500
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <clg@fr.ibm.com>;
	Mon, 3 Nov 2014 14:57:44 -0000
Message-ID: <545797A0.5070602@fr.ibm.com>
Date: Mon, 03 Nov 2014 15:56:32 +0100
From: Cedric Le Goater <clg@fr.ibm.com>
MIME-Version: 1.0
References: <1414405406-653-1-git-send-email-clg@fr.ibm.com>
	<545796CE.2010706@suse.de>
In-Reply-To: <545796CE.2010706@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table
 headers in big endian
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: aik@ozlabs.ru, paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 11/03/2014 03:53 PM, Alexander Graf wrote:
> 
> 
> On 27.10.14 11:23, Cédric Le Goater wrote:
>> Currently, when the page tables are saved, the kvm_get_htab_header structs 
>> and the ptes are assumed being big endian and dumped as a indistinct blob 
>> in the statefile. This is no longer true when the host is little endian 
>> and this breaks restoration.
>>
>> This patch unfolds the kvmppc_save_htab routine to write explicitly the 
>> kvm_get_htab_header structs in big endian. The ptes are left untouched.
>>
>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
>> Cc: paulus@samba.org
>> Cc: aik@ozlabs.ru
>> Cc: gkurz@linux.vnet.ibm.com
> 
> LGTM :)

OK then. I will resend as a PATCH, along with the kvm kernel patch which is 
just a couple of lines. Then, we can start testing cross-endian migration !

Thanks,

C.