From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XlJCE-0007sc-VS
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:05:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XlJC7-0002eA-GQ
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:05:30 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49068 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XlJC7-0002e6-AH
	for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:05:23 -0500
Message-ID: <545799AF.4040704@suse.de>
Date: Mon, 03 Nov 2014 16:05:19 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1414561053-29381-1-git-send-email-antonynpavlov@gmail.com>
In-Reply-To: <1414561053-29381-1-git-send-email-antonynpavlov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] qemu-log: add log category for MMU info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Antony Pavlov <antonynpavlov@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Blue Swirl <blauwirbel@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>



On 29.10.14 06:37, Antony Pavlov wrote:
> Running barebox on qemu-system-mips* with '-d unimp' overloads
> stderr by very very many mips_cpu_handle_mmu_fault() messages:
> 
>   mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 00000000180003fd prot 3
>   mips_cpu_handle_mmu_fault address=a0800884 ret 0 physical 0000000000800884 prot 3
>   mips_cpu_handle_mmu_fault pc a080cd80 ad b80003fd rw 0 mmu_idx 0
> 
> So it's very difficult to find LOG_UNIMP message.
> 
> The mips_cpu_handle_mmu_fault() messages appears on enabling ANY
> logging! It's not very handy.
> 
> Adding separate log category for *_cpu_handle_mmu_fault()
> logging fixes the problem.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Have you benchmarked the performance delta with this patch applied? Just
boot up a random small PPC guest that shuts down immediately and "time"
it with and without the patch applied.


Alex