From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJGn-0004JG-Lc for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:10:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJGi-0003mN-7z for qemu-devel@nongnu.org; Mon, 03 Nov 2014 10:10:13 -0500 Message-ID: <54579ACE.3010704@suse.de> Date: Mon, 03 Nov 2014 16:10:06 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1414405406-653-1-git-send-email-clg@fr.ibm.com> <545796CE.2010706@suse.de> <545797A0.5070602@fr.ibm.com> In-Reply-To: <545797A0.5070602@fr.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cedric Le Goater Cc: aik@ozlabs.ru, paulus@samba.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 03.11.14 15:56, Cedric Le Goater wrote: > On 11/03/2014 03:53 PM, Alexander Graf wrote: >> >> >> On 27.10.14 11:23, C=C3=A9dric Le Goater wrote: >>> Currently, when the page tables are saved, the kvm_get_htab_header st= ructs=20 >>> and the ptes are assumed being big endian and dumped as a indistinct = blob=20 >>> in the statefile. This is no longer true when the host is little endi= an=20 >>> and this breaks restoration. >>> >>> This patch unfolds the kvmppc_save_htab routine to write explicitly t= he=20 >>> kvm_get_htab_header structs in big endian. The ptes are left untouche= d. >>> >>> Signed-off-by: C=C3=A9dric Le Goater >>> Cc: paulus@samba.org >>> Cc: aik@ozlabs.ru >>> Cc: gkurz@linux.vnet.ibm.com >> >> LGTM :) >=20 > OK then. I will resend as a PATCH, along with the kvm kernel patch whic= h is=20 > just a couple of lines. Then, we can start testing cross-endian migrati= on ! Awesome! Looking forward to it :). Alex