From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlKGe-0007BG-GQ for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:14:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlKGZ-00060A-2D for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:14:08 -0500 Sender: Paolo Bonzini Message-ID: <5457A9B7.7030908@redhat.com> Date: Mon, 03 Nov 2014 17:13:43 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414742525-18639-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1414742525-18639-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sw@weilnetz.de On 31/10/2014 09:02, SeokYeon Hwang wrote: > Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or later. > > Signed-off-by: SeokYeon Hwang > --- > block/vdi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/vdi.c b/block/vdi.c > index 19701ee..e1d211c 100644 > --- a/block/vdi.c > +++ b/block/vdi.c > @@ -137,12 +137,14 @@ static inline int uuid_is_null(const uuid_t uu) > return memcmp(uu, null_uuid, sizeof(uuid_t)) == 0; > } > > +# if defined(CONFIG_VDI_DEBUG) > static inline void uuid_unparse(const uuid_t uu, char *out) > { > snprintf(out, 37, UUID_FMT, > uu[0], uu[1], uu[2], uu[3], uu[4], uu[5], uu[6], uu[7], > uu[8], uu[9], uu[10], uu[11], uu[12], uu[13], uu[14], uu[15]); > } > +# endif > #endif > > typedef struct { > Reviewed-by: Paolo Bonzini