From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlKJ4-0003QM-P5 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlKIz-0006k9-Aw for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:16:38 -0500 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:45349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlKIz-0006ji-0t for qemu-devel@nongnu.org; Mon, 03 Nov 2014 11:16:33 -0500 Received: by mail-la0-f49.google.com with SMTP id ge10so9463203lab.8 for ; Mon, 03 Nov 2014 08:16:31 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5457AA5B.50100@redhat.com> Date: Mon, 03 Nov 2014 17:16:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414731433-13257-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1414731433-13257-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] smbios: fixed compiler warning on clang > 3.4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: armbru@redhat.com, alex.williamson@hp.com On 31/10/2014 05:57, SeokYeon Hwang wrote: > Explicit casting to 'ram_addr_t' in order to avoid "-Wconstant-conversion" on clang 3.4 or later. > > Signed-off-by: SeokYeon Hwang > --- > hw/i386/smbios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c > index e3fa1b2..ace9c44 100644 > --- a/hw/i386/smbios.c > +++ b/hw/i386/smbios.c > @@ -836,7 +836,7 @@ void smbios_get_tables(uint8_t **tables, size_t *tables_len, > smbios_build_type_16_table(dimm_cnt); > > for (i = 0; i < dimm_cnt; i++) { > - smbios_build_type_17_table(i, GET_DIMM_SZ); > + smbios_build_type_17_table(i, (ram_addr_t)GET_DIMM_SZ); > } > > for (i = 0, instance = 0; i < e820_get_num_entries(); i++) { > I'm not sure what the problem is. Can you instead do something like: for (i = 0; i < dimm_cnt; i++) { - smbios_build_type_17_table(i, GET_DIMM_SZ); + uint64_t sz = (i < dimm_cnt - 1) ? MAX_DIMM_SZ : ram_size % MAX_DIMM_SZ; + smbios_build_type_17_table(i, sz); } and change smbios_build_type_17_table to take simply a uint64_t? Using ram_addr_t is probably wrong. Paolo