From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlZgx-0005Fz-Gq for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:42:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlZgr-0004Rb-MP for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:42:19 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:33660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlZgr-0004RO-Fi for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:42:13 -0500 Received: by mail-wi0-f173.google.com with SMTP id n3so8686567wiv.0 for ; Tue, 04 Nov 2014 00:42:12 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54589160.5050400@redhat.com> Date: Tue, 04 Nov 2014 09:42:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415085167-6143-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1415085167-6143-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] smbios: changed for "smbios_build_type_17_table()" to take 'uint64_t' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: paolo.bonzini@gmail.com, armbru@redhat.com, alex.williamson@hp.com On 04/11/2014 08:12, SeokYeon Hwang wrote: > "smbios_build_type_17_table()" should take 'uint64_t' instead of 'ram_addr_t' because it should be able to handle (16ll * GiB). > Otherwise, clang (>= 3.4) produces compilation warning in "smbios_get_tables()". > > Signed-off-by: SeokYeon Hwang > --- > hw/i386/smbios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c > index 8a7ad48..4ad42ae 100644 > --- a/hw/i386/smbios.c > +++ b/hw/i386/smbios.c > @@ -669,7 +669,7 @@ static void smbios_build_type_16_table(unsigned dimm_cnt) > #define MAX_T17_STD_SZ 0x7FFF /* (32G - 1M), in Megabytes */ > #define MAX_T17_EXT_SZ 0x80000000 /* 2P, in Megabytes */ > > -static void smbios_build_type_17_table(unsigned instance, ram_addr_t size) > +static void smbios_build_type_17_table(unsigned instance, uint64_t size) > { > char loc_str[128]; > ram_addr_t size_mb; > Can you make a patch that replaces _all_ occurrences in hw/i386/smbios.c instead? Thanks, Paolo