From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XlZk5-0000ty-Ts
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:45:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XlZjw-0005JZ-SR
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:45:33 -0500
Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:34607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XlZjw-0005It-LC
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 03:45:24 -0500
Received: by mail-wi0-f174.google.com with SMTP id d1so8692298wiv.13
	for <qemu-devel@nongnu.org>; Tue, 04 Nov 2014 00:45:23 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5458921B.3000807@redhat.com>
Date: Tue, 04 Nov 2014 09:45:15 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1414773522-7756-1-git-send-email-imammedo@redhat.com>	<1414773522-7756-4-git-send-email-imammedo@redhat.com>	<54576C56.9040704@redhat.com>	<20141103180013.5b4e2831@igors-macbook-pro.local>	<5457BC43.5020403@redhat.com>
	<20141103201110.2bf16a05@igors-macbook-pro.local>
In-Reply-To: <20141103201110.2bf16a05@igors-macbook-pro.local>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory
 slots for DIMM devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

On 03/11/2014 20:11, Igor Mammedov wrote:
>> > Understood.  But I think -m slots=too_much is not an important
>> > problem. What is problematic is filling those slots, which patch 1
>> > will help with.
> From user's pov it's still error, i.e. he asked on CLI for one amount
> of hotpluggable slots and couldn't use all of them at runtime.

But he cannot even with your patch, if he was off by just a couple
items.  So I don't think the improvement is worth the extra complication
of the code and the small layering violation.

Paolo