From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XlbwH-0006Gl-Up
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 06:06:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XlbwB-0002fh-Iw
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 06:06:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50417)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XlbwB-0002fO-AB
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 06:06:11 -0500
Message-ID: <5458B314.9050709@redhat.com>
Date: Tue, 04 Nov 2014 12:05:56 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1414639364-4499-1-git-send-email-famz@redhat.com>
	<1414639364-4499-10-git-send-email-famz@redhat.com>
In-Reply-To: <1414639364-4499-10-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 09/10] qmp: Add dirty bitmap 'enabled'
	field in query-block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Benoit Canet <benoit@irqsave.net>, Vladimir Sementsov-Ogievskij <etendren@gmail.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, John Snow <jsnow@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jd <jd_jedi@convirture.com>, Paolo Bonzini <pbonzini@redhat.com>

On 2014-10-30 at 04:22, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block.c              | 1 +
>   qapi/block-core.json | 5 ++++-
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index e574faa..f4d145c 100644
> --- a/block.c
> +++ b/block.c
> @@ -5375,6 +5375,7 @@ BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
>               ((int64_t) BDRV_SECTOR_SIZE << hbitmap_granularity(bm->bitmap));

Although just context, this could use bdrv_dirty_bitmap_granularity() or 
bm->granularity.

>           info->has_name = !!bm->name;
>           info->name = info->has_name ? g_strdup(bm->name) : NULL;
> +        info->enabled = bm->enabled;
>           entry->value = info;
>           *plist = entry;
>           plist = &entry->next;
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e225220..edd74c8 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -313,10 +313,13 @@
>   #
>   # @granularity: granularity of the dirty bitmap in bytes (since 1.4)
>   #
> +# @enabled: whether the dirty bitmap is enabled (Since 2.3)
> +#
>   # Since: 1.3
>   ##
>   { 'type': 'BlockDirtyInfo',
> -  'data': {'*name': 'str', 'count': 'int', 'granularity': 'int'} }
> +  'data': {'*name': 'str', 'count': 'int', 'granularity': 'int',
> +           'enabled': 'bool'} }
>   
>   ##
>   # @BlockInfo:

Reviewed-by: Max Reitz <mreitz@redhat.com>