From: Alexander Graf <agraf@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define
Date: Tue, 04 Nov 2014 14:39:00 +0100 [thread overview]
Message-ID: <5458D6F4.6010109@suse.de> (raw)
In-Reply-To: <20141104125132.1601d95d.cornelia.huck@de.ibm.com>
On 04.11.14 12:51, Cornelia Huck wrote:
> On Tue, 4 Nov 2014 11:41:11 +0100
> Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>> Add pause key to the list of compatibility defines.
>> Fixes the build with older gtk versions.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>> ui/gtk.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index de564cc..2f3e716 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -128,6 +128,7 @@ static inline void gdk_drawable_get_size(GdkWindow *w, gint *ww, gint *wh)
>> #define GDK_KEY_q GDK_q
>> #define GDK_KEY_plus GDK_plus
>> #define GDK_KEY_minus GDK_minus
>> +#define GDK_KEY_pause GDK_pause
>
> This needs to be _Pause with a capital 'P', otherwise the build still
> fails.
... and in case you do the same mistake as me, it needs to be an upper
case P on both pauses ;).
Alex
next prev parent reply other threads:[~2014-11-04 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 10:41 [Qemu-devel] [PULL 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions Gerd Hoffmann
2014-11-04 10:41 ` [Qemu-devel] [PULL 1/5] gtk: Grab accel_group from GtkDisplayState Gerd Hoffmann
2014-11-04 10:41 ` [Qemu-devel] [PULL 2/5] gtk: Install fullscreen accelerator on toplevel window Gerd Hoffmann
2014-11-04 10:41 ` [Qemu-devel] [PULL 3/5] gtk: Install vc accelerators on parent window Gerd Hoffmann
2014-11-04 10:41 ` [Qemu-devel] [PULL 4/5] gtk: Hide the menubar when in fullscreen mode (lp 1294898) Gerd Hoffmann
2014-11-04 10:41 ` [Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define Gerd Hoffmann
2014-11-04 11:51 ` Cornelia Huck
2014-11-04 13:39 ` Alexander Graf [this message]
2014-11-04 12:57 ` [Qemu-devel] [PULL 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions Peter Maydell
2014-11-04 13:38 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458D6F4.6010109@suse.de \
--to=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).