From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35468)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XleKD-0001kv-Qd
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 08:39:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XleK6-0001Wo-BK
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 08:39:09 -0500
Received: from cantor2.suse.de ([195.135.220.15]:42756 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XleK6-0001Wg-51
	for qemu-devel@nongnu.org; Tue, 04 Nov 2014 08:39:02 -0500
Message-ID: <5458D6F4.6010109@suse.de>
Date: Tue, 04 Nov 2014 14:39:00 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1415097671-15343-1-git-send-email-kraxel@redhat.com>	<1415097671-15343-6-git-send-email-kraxel@redhat.com>
	<20141104125132.1601d95d.cornelia.huck@de.ibm.com>
In-Reply-To: <20141104125132.1601d95d.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>



On 04.11.14 12:51, Cornelia Huck wrote:
> On Tue,  4 Nov 2014 11:41:11 +0100
> Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
>> Add pause key to the list of compatibility defines.
>> Fixes the build with older gtk versions.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  ui/gtk.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index de564cc..2f3e716 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -128,6 +128,7 @@ static inline void gdk_drawable_get_size(GdkWindow *w, gint *ww, gint *wh)
>>  #define GDK_KEY_q GDK_q
>>  #define GDK_KEY_plus GDK_plus
>>  #define GDK_KEY_minus GDK_minus
>> +#define GDK_KEY_pause GDK_pause
> 
> This needs to be _Pause with a capital 'P', otherwise the build still
> fails.

... and in case you do the same mistake as me, it needs to be an upper
case P on both pauses ;).


Alex