From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlgLh-0002dg-7H for qemu-devel@nongnu.org; Tue, 04 Nov 2014 10:48:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlgLb-0003Da-Bg for qemu-devel@nongnu.org; Tue, 04 Nov 2014 10:48:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlgLb-0003DW-47 for qemu-devel@nongnu.org; Tue, 04 Nov 2014 10:48:43 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4FmfT4006284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 4 Nov 2014 10:48:42 -0500 Message-ID: <5458F553.9020103@redhat.com> Date: Tue, 04 Nov 2014 16:48:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415058979-16604-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1415058979-16604-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] ahci: fis decomposition improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 04/11/2014 00:56, John Snow wrote: > This patch series may require, and is based on another > AHCI series pending on-list: > http://lists.gnu.org/archive/html/qemu-devel/2014-10/msg04143.html > > This series aims to improve the way that handle_cmd > reads and behaves in interpreting the FIS packets > received by the AHCI HBA. This series used to be > part of a larger RFC, but has since been pared > down to a more focused series. > > Previous RFC: > http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg02694.html > > Patch 1 is a subset of the previously posted > "AHCI: Rename NCQFIS structure fields" patch. > This subset is just aimed at improving the readability > of the FIS decomposition in handle_cmd for now. > > Patch 2 is nearly the same as "AHCI: Fix FIS decomposition" > which has yet to be reviewed. > > Patches 3, 4, and 5 have been inspected previously, and should > be identical. > "ide/ahci: Reorder error cases in handle_cmd" > "ahci: Check cmd_fis[1] more explicitly" > "ahci: factor out FIS decomposition" Reviewed-by: Paolo Bonzini