From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlgum-0004VG-S8 for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:25:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlguh-00080o-UR for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:25:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlguh-00080j-N9 for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:24:59 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4GOwnk021925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 4 Nov 2014 11:24:59 -0500 Message-ID: <5458FDD8.7030207@redhat.com> Date: Tue, 04 Nov 2014 17:24:56 +0100 From: Eric Blake MIME-Version: 1.0 References: <1414979247-11194-1-git-send-email-famz@redhat.com> <1414979247-11194-3-git-send-email-famz@redhat.com> In-Reply-To: <1414979247-11194-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M4pCmF8ru8C6CF8WxItjSbPACgGnhrvH6" Subject: Re: [Qemu-devel] [PATCH v2 RESEND 2/4] block: Add blockdev-backup to transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M4pCmF8ru8C6CF8WxItjSbPACgGnhrvH6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2014 02:47 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++= ++++ > qapi-schema.json | 4 ++++ > qapi/block-core.json | 2 +- > 3 files changed, 53 insertions(+), 1 deletion(-) >=20 > +++ b/qapi-schema.json > @@ -1254,11 +1254,15 @@ > # > # A discriminated record of operations that can be performed with > # @transaction. > +# > +# Since 1.1 > +# blockdev-backup since 2.3 > ## It might be nice to document the addition of other branches of this union (not all of them were in 1.1). But even this is a strict improvement, so I can live with it. > { 'union': 'TransactionAction', > 'data': { > 'blockdev-snapshot-sync': 'BlockdevSnapshot', > 'drive-backup': 'DriveBackup', > + 'blockdev-backup': 'BlockdevBackup', > 'abort': 'Abort', > 'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal' > } } > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 838b7d6..8c0592f 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -698,7 +698,7 @@ > # If an error occurs during a guest write request, the device's rerror= /werror > # actions will be used. > # > -# Since: 2.2 > +# Since: 2.3 Did you mean to squash this hunk into 1/4? > ## > { 'type': 'BlockdevBackup', > 'data': { 'device': 'str', 'target': 'str', >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M4pCmF8ru8C6CF8WxItjSbPACgGnhrvH6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUWP3YAAoJEKeha0olJ0Nq+e4H/igy5reKfY1xRKRpa31QHABL 5cHQ026sZVMZq9wpZjodW1UL0n+46oaCkUuAPRTeeJ86TWb17hic4Ui3pGGIIHZ7 FBlpA/H0S1oiI47EyoZ3efimDXbGeLxt3M1ZJqc7xn8BXeG39g19dnCC88UorJVa vu7Sm5SuwMIfL/6JzmwlJa4zcOpAaK0OOQHF8L+T7ibsRCrTEwzZKNf33tkT7rAg q7Dt/UHe7Ll1xDvg9jiaefkhAq43cD5BHnErqLAQUOQo186kHmv4fbdv4kVv0mOa V0X/oWupU81/+a8maMFjt4bBR/syWdffcZ87wb2d7PVz2GEt7UFlLKVJ9Anpydw= =AvSB -----END PGP SIGNATURE----- --M4pCmF8ru8C6CF8WxItjSbPACgGnhrvH6--