From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlgx1-0007sG-WB for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:27:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlgwx-0000j7-3W for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:27:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlgwu-0000he-0K for qemu-devel@nongnu.org; Tue, 04 Nov 2014 11:27:19 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA4GREpa000418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 4 Nov 2014 11:27:15 -0500 Message-ID: <5458FE60.80003@redhat.com> Date: Tue, 04 Nov 2014 17:27:12 +0100 From: Eric Blake MIME-Version: 1.0 References: <1414979247-11194-1-git-send-email-famz@redhat.com> <1414979247-11194-4-git-send-email-famz@redhat.com> In-Reply-To: <1414979247-11194-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sGKAVdmOM4PeToPSmG8tut7bSL6HWmV2v" Subject: Re: [Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for transaction types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sGKAVdmOM4PeToPSmG8tut7bSL6HWmV2v Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2014 02:47 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qapi-schema.json | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 1ddd395..48ba583 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1256,6 +1256,8 @@ > # @transaction. > # > # Since 1.1 > +# drive-backup since 1.6 > +# blockdev-snapshot-internal-sync since 1.7 > # blockdev-backup since 2.3 Aha - you (almost) addressed my comment from 2/4 - you missed that abort was also added in 1.6, alongside drive-backup. I'd be okay if you squashed this in with 2/4. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sGKAVdmOM4PeToPSmG8tut7bSL6HWmV2v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUWP5gAAoJEKeha0olJ0Nq20kH/0RCAlBbaiGnSfPQgWSVhuNR Di/RGjNOMx/WFbFQRxz8m2HAmmYqw4ttPtreZwfLOxoRwlRw/rOKifRdbBpDy/oI d1Ue3OJ2A6TSg4HHAKAOgRionW6INGND7X779Yex3h91Md9ZVYjvo49eFAeBC+jM qUOp85NBGeDuC3HjizdoUS/fvlV5Ki1wwR+VrbrxtuvXiw6NIMWz3dNM/AmE1Dbp 94kHYgU+HikKy4KvC2jh5De3vjwPqmlgWWgz7SSaVw6kbA5h9+VWcwlb+Y28YWA9 xO5EeQy6wY3YDXEfKyE+O7py4RN1dUo4zYwh/2t4mQ1WR5BVW0H3Y5ZJNEXOMXc= =z84x -----END PGP SIGNATURE----- --sGKAVdmOM4PeToPSmG8tut7bSL6HWmV2v--