From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] qdev: Validate class name for -device <class>, help
Date: Tue, 04 Nov 2014 17:51:12 +0100 [thread overview]
Message-ID: <54590400.30405@suse.de> (raw)
In-Reply-To: <20141103151414.GD4609@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
Am 03.11.2014 um 16:14 schrieb Stefan Hajnoczi:
> On Sat, Nov 01, 2014 at 01:56:08PM -0200, Eduardo Habkost wrote:
>> This fixes the following crashes:
>>
>> $ qemu-system-x86_64 -device x86_64-cpu,help
>> **
>> ERROR:qom/object.c:336:object_initialize_with_type: assertion failed: (type->abstract == false)
>> Aborted (core dumped)
>> $ qemu-system-x86_64 -device host-x86_64-cpu,help
>> qemu-system-x86_64: /home/ehabkost/rh/proj/virt/qemu/target-i386/cpu.c:1329: host_x86_cpu_initfn: Assertion `(kvm_allowed)' failed.
>> Aborted (core dumped)
>>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>
> Haven't reviewed in detail but thanks for fixing this.
Thanks, applied to qom-next as is:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-11-04 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:56 [Qemu-devel] [PATCH 0/3] qdev: Validate class name for -device <class>, help Eduardo Habkost
2014-11-01 15:56 ` [Qemu-devel] [PATCH 1/3] qdev: Create qdev_get_device_class() function Eduardo Habkost
2014-11-01 16:46 ` Andreas Färber
2014-11-01 17:03 ` Eduardo Habkost
2014-11-01 15:56 ` [Qemu-devel] [PATCH 2/3] qdev: Move error printing to the end of qdev_device_help() Eduardo Habkost
2014-11-01 15:56 ` [Qemu-devel] [PATCH 3/3] qdev: Use qdev_device_add_get_class() for -device <type>, help Eduardo Habkost
2014-11-01 16:40 ` Andreas Färber
2014-11-01 16:45 ` Eduardo Habkost
2014-11-01 16:48 ` Andreas Färber
2014-11-01 17:22 ` Eduardo Habkost
2014-11-03 15:14 ` [Qemu-devel] [PATCH 0/3] qdev: Validate class name for -device <class>, help Stefan Hajnoczi
2014-11-04 16:51 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54590400.30405@suse.de \
--to=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).