From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xlxty-0004a0-At
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 05:33:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xlxts-0007xd-Td
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 05:33:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xlxts-0007xV-Mc
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 05:33:16 -0500
Message-ID: <5459FCE1.9060903@redhat.com>
Date: Wed, 05 Nov 2014 11:33:05 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1414661809-21383-1-git-send-email-borntraeger@de.ibm.com>
	<1414661809-21383-8-git-send-email-borntraeger@de.ibm.com>
In-Reply-To: <1414661809-21383-8-git-send-email-borntraeger@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/9] valgrind/i386: avoid false positives
 on KVM_GET_MSRS ioctl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 30/10/2014 10:36, Christian Borntraeger wrote:
> struct kvm_msrs contains a pad field. Lets initialize this pad
> field. A designated initializer seems not appropriate here, as
> struct kvm_msrs is embedded in the msr_data structure.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

What about this:

    msr_data.info = (struct kvm_msrs) {
        .nmsrs = n
    };

?  It would also be applicable to other uses of kvm_msrs.

Also, you're missing one occurrence in kvm_put_msr_feature_control.

Paolo