From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm1zr-0001ri-Sj for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:55:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm1zi-0006U5-H7 for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:55:43 -0500 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:63310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm1zi-0006U0-3H for qemu-devel@nongnu.org; Wed, 05 Nov 2014 09:55:34 -0500 Received: by mail-wg0-f48.google.com with SMTP id m15so1114553wgh.7 for ; Wed, 05 Nov 2014 06:55:33 -0800 (PST) Sender: Paolo Bonzini Message-ID: <545A3A61.50001@redhat.com> Date: Wed, 05 Nov 2014 15:55:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415182311-13799-1-git-send-email-syeon.hwang@samsung.com> <20141105124609.GA4354@redhat.com> <87lhnpn5y1.fsf@blackfin.pond.sub.org> <545A23A7.7090401@redhat.com> <20141105132815.GA4884@redhat.com> In-Reply-To: <20141105132815.GA4884@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] pci: fixed mismatch of error-handling between pci_qdev_init() and qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Markus Armbruster , SeokYeon Hwang On 05/11/2014 14:28, Michael S. Tsirkin wrote: > > I think bypassing the question by converting to realize makes the most > > sense... > > I'm fine with doing that but Markus's patches wouldn't > yet have solved the problem by themselves since init > is still around, right? > > This probably means fixing this bug can't justify > merging the realize patchset after freeze. Yes, I agree. I meant that the API is not very well defined. I would handle everything else on a case-by-case basis, by reviewing each init function that is converted to realize. Since the patch was for an out-of-tree device, it can wait for 2.3 anyway. Paolo