From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XmGuq-0003Da-Kw
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 01:51:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XmGuh-0000OU-Kh
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 01:51:32 -0500
Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:50467)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XmGuh-0000OD-AL
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 01:51:23 -0500
Received: by mail-la0-f44.google.com with SMTP id gf13so2091172lab.3
	for <qemu-devel@nongnu.org>; Wed, 05 Nov 2014 22:51:22 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <545A61D6.6010800@twiddle.net>
Date: Wed, 05 Nov 2014 18:43:50 +0100
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com>
	<1414546928-54642-11-git-send-email-yongbok.kim@imgtec.com>
In-Reply-To: <1414546928-54642-11-git-send-email-yongbok.kim@imgtec.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 10/20] target-mips: add MSA I8 format
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: leon.alrae@imgtec.com, aurelien@aurel32.net

On 10/29/2014 02:41 AM, Yongbok Kim wrote:
> +void helper_msa_shf_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
> +                       uint32_t ws, uint32_t imm)
> +{
> +    wr_t *pwd = &(env->active_fpu.fpr[wd].wr);
> +    wr_t *pws = &(env->active_fpu.fpr[ws].wr);
> +    wr_t wx, *pwx = &wx;
> +    uint32_t i;
> +
> +    switch (df) {
> +    case DF_BYTE:
> +        for (i = 0; i < DF_ELEMENTS(DF_BYTE); i++) {
> +            pwx->b[i] = pws->b[SHF_POS(i, imm)];
> +        }
> +        break;
> +    case DF_HALF:
> +        for (i = 0; i < DF_ELEMENTS(DF_HALF); i++) {
> +            pwx->h[i] = pws->h[SHF_POS(i, imm)];
> +        }
> +        break;

Why pass DF to decode at runtime?  It's better to fully decode this at
translate time and call the correct function.


r~