From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm963-0001E3-FG for qemu-devel@nongnu.org; Wed, 05 Nov 2014 17:30:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm95x-00049u-6I for qemu-devel@nongnu.org; Wed, 05 Nov 2014 17:30:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm95w-00049h-Uf for qemu-devel@nongnu.org; Wed, 05 Nov 2014 17:30:29 -0500 Message-ID: <545AA500.3040505@redhat.com> Date: Wed, 05 Nov 2014 17:30:24 -0500 From: John Snow MIME-Version: 1.0 References: <1414051962-3795-1-git-send-email-marc.mari.barcelo@gmail.com> In-Reply-To: <1414051962-3795-1-git-send-email-marc.mari.barcelo@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] libqos: Convert malloc-pc allocator to a generic allocator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 10/23/2014 04:12 AM, Marc Mar=C3=AD wrote: > The allocator in malloc-pc has been extracted, so it can be used in eve= ry arch. > This operation showed that both the alloc and free functions can be als= o > generic. > Because of this, the QGuestAllocator has been removed from is function = to wrap > the alloc and free function, and now just contains the allocator parame= ters. > As a result, only the allocator initalizer and unitializer are arch dep= endent. > > Signed-off-by: Marc Mar=C3=AD > Reviewed-by: Stefan Hajnoczi > --- > tests/Makefile | 2 +- > tests/libqos/malloc-pc.c | 280 +------------------------------------= --------- > tests/libqos/malloc-pc.h | 11 +- > tests/libqos/malloc.c | 270 +++++++++++++++++++++++++++++++++++++= +++++++ > tests/libqos/malloc.h | 45 +++++--- > 5 files changed, 309 insertions(+), 299 deletions(-) > create mode 100644 tests/libqos/malloc.c > [snip] I previously acknowledged V1 mistakenly instead of V2 here, and have=20 seen no activity since -- so here's another Reviewed-by in case someone=20 has a script waiting for this explicit reply. I'll also add that I pulled the patch into my testing tree and ran it=20 through Valgrind and my AHCI test suite and it behaves perfectly well. Reviewed-by: John Snow