From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Weil <sw@weilnetz.de>,
Jeff Cody <jcody@redhat.com>, Peter Lieven <pl@kamp.de>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher
Date: Thu, 06 Nov 2014 10:25:03 +0100 [thread overview]
Message-ID: <545B3E6F.9090601@redhat.com> (raw)
In-Reply-To: <1414491152-26952-1-git-send-email-mreitz@redhat.com>
On 2014-10-28 at 11:12, Max Reitz wrote:
> The block layer read and write functions do not like requests which are
> bigger than INT_MAX bytes. Since the VDI bmap is read and written in a
> single operation, its size is therefore limited accordingly. This
> reduces the maximum VDI image size supported by QEMU to half of what it
> currently is (down to approximately 512 TB).
>
> The VDI test 084 has to be adapted accordingly. Actually, one could
> clearly see that it was broken from the "Could not open
> 'TEST_DIR/t.IMGFMT': Invalid argument" line for an image which was
> supposed to work just fine.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2:
> - Reducing the size to just under 512 TB wasn't enough because the bmap
> size is rounded up on sector boundaries; fixed (thanks for testing,
> Peter)
> - Finally a patch regarding this problem that I tested myself :-)
Ping
next prev parent reply other threads:[~2014-11-06 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 10:12 [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher Max Reitz
2014-11-06 9:25 ` Max Reitz [this message]
2014-11-06 13:06 ` Stefan Hajnoczi
2014-11-06 13:28 ` Peter Lieven
2014-11-07 9:04 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B3E6F.9090601@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).