From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1XmLZA-0008EV-KU
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 06:49:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1XmLZ4-0005sM-Gr
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 06:49:28 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:49724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1XmLZ4-0005sA-AV
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 06:49:22 -0500
Message-ID: <545B603F.3060004@imgtec.com>
Date: Thu, 6 Nov 2014 11:49:19 +0000
From: Yongbok Kim <yongbok.kim@imgtec.com>
MIME-Version: 1.0
References: <1414546928-54642-1-git-send-email-yongbok.kim@imgtec.com>
	<1414546928-54642-11-git-send-email-yongbok.kim@imgtec.com>
	<545A61D6.6010800@twiddle.net>
In-Reply-To: <545A61D6.6010800@twiddle.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 10/20] target-mips: add MSA I8 format
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: leon.alrae@imgtec.com, aurelien@aurel32.net

On 05/11/2014 17:43, Richard Henderson wrote:
> On 10/29/2014 02:41 AM, Yongbok Kim wrote:
>> +void helper_msa_shf_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
>> +                       uint32_t ws, uint32_t imm)
>> +{
>> +    wr_t *pwd = &(env->active_fpu.fpr[wd].wr);
>> +    wr_t *pws = &(env->active_fpu.fpr[ws].wr);
>> +    wr_t wx, *pwx = &wx;
>> +    uint32_t i;
>> +
>> +    switch (df) {
>> +    case DF_BYTE:
>> +        for (i = 0; i < DF_ELEMENTS(DF_BYTE); i++) {
>> +            pwx->b[i] = pws->b[SHF_POS(i, imm)];
>> +        }
>> +        break;
>> +    case DF_HALF:
>> +        for (i = 0; i < DF_ELEMENTS(DF_HALF); i++) {
>> +            pwx->h[i] = pws->h[SHF_POS(i, imm)];
>> +        }
>> +        break;
> Why pass DF to decode at runtime?  It's better to fully decode this at
> translate time and call the correct function.
>
>
> r~
Hi Richard,

Agreed. DF is already known in translation time.
I do have a plan to improve efficiency of MSA implementation.

Regards,
Yongbok