From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmN7X-0004hv-EF for qemu-devel@nongnu.org; Thu, 06 Nov 2014 08:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmN7R-0001Dx-Ob for qemu-devel@nongnu.org; Thu, 06 Nov 2014 08:29:03 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:42130 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmN7R-0001DV-EC for qemu-devel@nongnu.org; Thu, 06 Nov 2014 08:28:57 -0500 Message-ID: <545B7794.1010202@kamp.de> Date: Thu, 06 Nov 2014 14:28:52 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1414491152-26952-1-git-send-email-mreitz@redhat.com> <20141106130632.GE12646@stefanha-thinkpad.redhat.com> In-Reply-To: <20141106130632.GE12646@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even futher List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Max Reitz Cc: Kevin Wolf , Stefan Weil , Jeff Cody , qemu-devel@nongnu.org On 06.11.2014 14:06, Stefan Hajnoczi wrote: > On Tue, Oct 28, 2014 at 11:12:32AM +0100, Max Reitz wrote: >> The block layer read and write functions do not like requests which are >> bigger than INT_MAX bytes. Since the VDI bmap is read and written in a >> single operation, its size is therefore limited accordingly. This >> reduces the maximum VDI image size supported by QEMU to half of what it >> currently is (down to approximately 512 TB). >> >> The VDI test 084 has to be adapted accordingly. Actually, one could >> clearly see that it was broken from the "Could not open >> 'TEST_DIR/t.IMGFMT': Invalid argument" line for an image which was >> supposed to work just fine. >> >> Signed-off-by: Max Reitz >> --- >> v2: >> - Reducing the size to just under 512 TB wasn't enough because the bmap >> size is rounded up on sector boundaries; fixed (thanks for testing, >> Peter) >> - Finally a patch regarding this problem that I tested myself :-) >> --- >> block/vdi.c | 14 ++++++++++++-- >> tests/qemu-iotests/084 | 14 +++++++------- >> tests/qemu-iotests/084.out | 13 ++++++++----- >> 3 files changed, 27 insertions(+), 14 deletions(-) > Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Lieven