From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: mtosatti@redhat.com, kraxel@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent
Date: Fri, 07 Nov 2014 09:50:39 +0100 [thread overview]
Message-ID: <545C87DF.7010306@redhat.com> (raw)
In-Reply-To: <545C87B3.8060107@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On 11/07/2014 09:49 AM, Eric Blake wrote:
> On 11/07/2014 05:41 AM, Amos Kong wrote:
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> ---
>> qapi-schema.json | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Shoot - I hit "send" too soon.
>
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 24379ab..a1573d8 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3231,6 +3231,11 @@
>> #
>> # Input event union.
>> #
>> +# @key: Input event of Keyboard
>> +# @btn: Input event of pointer bottons
s/bottons/buttons/ before my R-b applies (maintainer could opt to do
this without needing a v2)
>> +# @rel: Input event of relative pointer motion
>> +# @abs: Input event of absolute pointer motion
>> +#
>> # Since: 2.0
>> ##
>> { 'union' : 'InputEvent',
>>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-07 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 4:41 [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent Amos Kong
2014-11-07 4:41 ` [Qemu-devel] [PATCH for-2.2 2/2] QMP/input-send-event: make console parameter optional Amos Kong
2014-11-07 8:53 ` Eric Blake
2014-11-07 8:49 ` [Qemu-devel] [PATCH for-2.2 1/2] QMP/input-send-event: update document of union InputEvent Eric Blake
2014-11-07 8:50 ` Eric Blake [this message]
2014-11-13 10:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C87DF.7010306@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).