From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XmfSp-00021y-UB
	for qemu-devel@nongnu.org; Fri, 07 Nov 2014 04:04:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XmfSl-0002rv-4n
	for qemu-devel@nongnu.org; Fri, 07 Nov 2014 04:04:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XmfSk-0002rp-US
	for qemu-devel@nongnu.org; Fri, 07 Nov 2014 04:04:11 -0500
Message-ID: <545C8B00.3090707@redhat.com>
Date: Fri, 07 Nov 2014 10:04:00 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1414491152-26952-1-git-send-email-mreitz@redhat.com>
In-Reply-To: <1414491152-26952-1-git-send-email-mreitz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] block/vdi: Limit maximum size even
	futher
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Weil <sw@weilnetz.de>, Jeff Cody <jcody@redhat.com>, Peter Lieven <pl@kamp.de>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-10-28 at 11:12, Max Reitz wrote:
> The block layer read and write functions do not like requests which are
> bigger than INT_MAX bytes. Since the VDI bmap is read and written in a
> single operation, its size is therefore limited accordingly. This
> reduces the maximum VDI image size supported by QEMU to half of what it
> currently is (down to approximately 512 TB).
>
> The VDI test 084 has to be adapted accordingly. Actually, one could
> clearly see that it was broken from the "Could not open
> 'TEST_DIR/t.IMGFMT': Invalid argument" line for an image which was
> supposed to work just fine.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2:
> - Reducing the size to just under 512 TB wasn't enough because the bmap
>    size is rounded up on sector boundaries; fixed (thanks for testing,
>    Peter)
> - Finally a patch regarding this problem that I tested myself :-)
> ---
>   block/vdi.c                | 14 ++++++++++++--
>   tests/qemu-iotests/084     | 14 +++++++-------
>   tests/qemu-iotests/084.out | 13 ++++++++-----
>   3 files changed, 27 insertions(+), 14 deletions(-)

Thanks for the reviews, applied to my block branch:

https://github.com/XanClic/qemu/commits/block