From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xmh2O-0006Bh-Ne for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:45:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xmh2K-00048p-4e for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:45:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xmh2J-00048Z-T8 for qemu-devel@nongnu.org; Fri, 07 Nov 2014 05:45:00 -0500 Message-ID: <545CA29E.2070403@redhat.com> Date: Fri, 07 Nov 2014 11:44:46 +0100 From: Eric Blake MIME-Version: 1.0 References: <20141107103123.6136.18545.stgit@PASHA-ISP> <20141107103144.6136.52899.stgit@PASHA-ISP> In-Reply-To: <20141107103144.6136.52899.stgit@PASHA-ISP> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eX4CPu3DhfQeQD5esOcIe2WNiPXJfmSHJ" Subject: Re: [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pbonzini@redhat.com, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eX4CPu3DhfQeQD5esOcIe2WNiPXJfmSHJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/07/2014 11:31 AM, Pavel Dovgalyuk wrote: > This patch adds global variables, defines, functions declarations, > and function stubs for deterministic VM replay used by external modules= =2E >=20 > Signed-off-by: Pavel Dovgalyuk > --- Just focusing on interface review: > +++ b/qapi-schema.json > @@ -3508,3 +3508,35 @@ > # Since: 2.1 > ## > { 'command': 'rtc-reset-reinjection' } > + > +## > +# ReplayMode: > +# > +# Mode of the replay subsystem. > +# > +# @none: normal execution mode. Replay or record are not enabled. > +# > +# @record: record mode. All non-deterministic data is written into the= > +# replay log. > +# > +# @play: replay mode. Non-deterministic data required for system execu= tion > +# is read from the log. > +# > +# Since: 2.2 You've missed 2.2 freeze; this will have to be 2.3. > +## > +{ 'enum': 'ReplayMode', > + 'data': [ 'none', 'record', 'play' ] } > + > +## > +# ReplaySubmode: > +# > +# Submode of the replay subsystem. > +# > +# @unknown: used for modes different from play. > +# > +# @normal: normal replay mode. > +# > +# Since: 2.2 Again, 2.3 > +## > +{ 'enum': 'ReplaySubmode', > + 'data': [ 'unknown', 'normal' ] } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eX4CPu3DhfQeQD5esOcIe2WNiPXJfmSHJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUXKKeAAoJEKeha0olJ0NqBzMH/2Rb7N8agTYgB0r1NZVZ6pxl 29lEXqzxdNbjmKv1Zx/uU7pwHTmnwGP0Q9IHddb3j3oVQb3kbuvXemyrSU2x0Zui QjQOl2stc5g4F9/DVg2dsZEKRrPxNlZ2x17OLMcel+kPF+obKMQsM6IotsnnNMQi ZMM2vrxc3XpTeSTXDJgVCUWy42Wi1Bn+DAejIrvy43UFrIafMjT5ODjnNRmNsVj/ Aieocv7sz9z0Hx2PICZOR/jz9b8Un+wHah3wnfV0bDEqpTPlpYZSlCunju5y8Yom e2jXHvfBPcCzJeh1bhyPQ7KgbED81gbe9Q2OFHEIxXk9neECs8COc4DOuqAKCPs= =8r+7 -----END PGP SIGNATURE----- --eX4CPu3DhfQeQD5esOcIe2WNiPXJfmSHJ--