From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmhYf-0005nU-D8 for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:18:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmhYa-0000Pm-F3 for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:18:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmhYa-0000Pi-8j for qemu-devel@nongnu.org; Fri, 07 Nov 2014 06:18:20 -0500 Message-ID: <545CAA6F.1010007@redhat.com> Date: Fri, 07 Nov 2014 12:18:07 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20141107103123.6136.18545.stgit@PASHA-ISP> <20141107103139.6136.68989.stgit@PASHA-ISP> In-Reply-To: <20141107103139.6136.68989.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v4 02/25] mc146818rtc: add missed field to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 07/11/2014 11:31, Pavel Dovgalyuk wrote: > This patch adds irq_reinject_on_ack_count field to VMState to allow correct > saving/loading the state of MC146818 RTC. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/timer/mc146818rtc.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c > index f18d128..2c4b650 100644 > --- a/hw/timer/mc146818rtc.c > +++ b/hw/timer/mc146818rtc.c > @@ -809,6 +809,7 @@ static void rtc_reset(void *opaque) > > s->cmos_data[RTC_REG_B] &= ~(REG_B_PIE | REG_B_AIE | REG_B_SQWE); > s->cmos_data[RTC_REG_C] &= ~(REG_C_UF | REG_C_IRQF | REG_C_PF | REG_C_AF); > + s->irq_reinject_on_ack_count = 0; > check_update_timer(s); > > qemu_irq_lower(s->irq); > This is already set below. If you need it here, please justify it in the commit message and move up the code that already sets it. Paolo