From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmmXa-0006JX-M1 for qemu-devel@nongnu.org; Fri, 07 Nov 2014 11:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmmXU-000848-6F for qemu-devel@nongnu.org; Fri, 07 Nov 2014 11:37:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmmXT-00083R-UT for qemu-devel@nongnu.org; Fri, 07 Nov 2014 11:37:32 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA7GbTIk007637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 7 Nov 2014 11:37:30 -0500 Message-ID: <545CF541.7020403@redhat.com> Date: Fri, 07 Nov 2014 17:37:21 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1414773522-7756-1-git-send-email-imammedo@redhat.com> <1414773522-7756-4-git-send-email-imammedo@redhat.com> <54576C56.9040704@redhat.com> <20141103180013.5b4e2831@igors-macbook-pro.local> <5457BC43.5020403@redhat.com> <20141103201110.2bf16a05@igors-macbook-pro.local> <5458921B.3000807@redhat.com> <20141104163905.35866f63@nial.usersys.redhat.com> <5458F3DF.4040003@redhat.com> <20141104171429.13ed86c0@nial.usersys.redhat.com> In-Reply-To: <20141104171429.13ed86c0@nial.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory slots for DIMM devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com On 04/11/2014 17:14, Igor Mammedov wrote: >> > Note that option ROM BARs (which are usually mapped only by firmware, >> > but also when accessed via sysfs) and device assignment both consume >> > memory slots. Slots occupied by pflash can also come and go, depending >> > on whether the flash is visible as ROM or in programming mode. > Then there is a bigger problem, once KVM slots are saturated QEMU will crash > if one of above actions from guest happens, and we can't even error out on them. Yes. I wish I had a better idea than checking for free memslots manually in all of them. Paolo