From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232
Date: Tue, 29 Jan 2019 16:23:38 -0500 [thread overview]
Message-ID: <545b40f9-a388-a2c2-d279-7f267b48a55a@redhat.com> (raw)
In-Reply-To: <20190123144610.8842-3-mreitz@redhat.com>
On 1/23/19 9:46 AM, Max Reitz wrote:
> This test creates no such file.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
(+1 to Eric's suggestion of reviving Jeff's patches. Maybe I'll take a
look once I get my downstream queue under control...)
> ---
> tests/qemu-iotests/232 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232
> index 0708b8b155..93e5d641a3 100755
> --- a/tests/qemu-iotests/232
> +++ b/tests/qemu-iotests/232
> @@ -29,7 +29,6 @@ status=1 # failure is the default!
> _cleanup()
> {
> _cleanup_test_img
> - rm -f $TEST_IMG.snap
> }
> trap "_cleanup; exit \$status" 0 1 2 3 15
>
>
next prev parent reply other threads:[~2019-01-29 21:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 14:46 [Qemu-devel] [PATCH 0/9] iotests: Fix some issues Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 1/9] iotests: Re-add filename filters Max Reitz
2019-01-29 21:22 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 2/9] iotests: Remove superfluous rm from 232 Max Reitz
2019-01-23 15:10 ` Eric Blake
2019-01-29 21:23 ` John Snow [this message]
2019-01-23 14:46 ` [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS Max Reitz
2019-01-29 21:26 ` John Snow
2019-01-30 13:05 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 4/9] iotests: Fix 207 to use QMP filters for qmp_log Max Reitz
2019-01-29 21:31 ` John Snow
2019-01-30 13:16 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 5/9] iotests: Fix 237 for Python 2.x Max Reitz
2019-01-29 21:21 ` John Snow
2019-01-30 13:06 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 6/9] iotests.py: Add is_str() Max Reitz
2019-01-29 21:35 ` John Snow
2019-01-30 13:23 ` Max Reitz
2019-01-23 14:46 ` [Qemu-devel] [PATCH 7/9] iotests.py: Filter filename in any string value Max Reitz
2019-01-29 21:36 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 8/9] iotests: Filter SSH paths Max Reitz
2019-01-29 21:40 ` John Snow
2019-01-23 14:46 ` [Qemu-devel] [PATCH 9/9] iotests.py: s/_/-/g on keys in qmp_log() Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545b40f9-a388-a2c2-d279-7f267b48a55a@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).