From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnjox-00084x-PS for qemu-devel@nongnu.org; Mon, 10 Nov 2014 02:55:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnjot-0000Yq-3m for qemu-devel@nongnu.org; Mon, 10 Nov 2014 02:55:31 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:64761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnjor-0000YG-LW for qemu-devel@nongnu.org; Mon, 10 Nov 2014 02:55:27 -0500 Message-ID: <54606F60.4090305@huawei.com> Date: Mon, 10 Nov 2014 15:55:12 +0800 From: Gonglei MIME-Version: 1.0 References: <1415362952-16047-1-git-send-email-hare@suse.de> <545F3794.2010200@ilande.co.uk> <546062EB.5080409@suse.de> <54606BB5.1060703@huawei.com> <54606E2B.2020602@suse.de> In-Reply-To: <54606E2B.2020602@suse.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] esp-pci: fixup deadlock with linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: Paolo Bonzini , Mark Cave-Ayland , "qemu-devel@nongnu.org" On 2014/11/10 15:50, Hannes Reinecke wrote: > On 11/10/2014 08:39 AM, Gonglei wrote: >> On 2014/11/10 15:02, Hannes Reinecke wrote: >> >>> On 11/09/2014 10:44 AM, Mark Cave-Ayland wrote: >>>> On 07/11/14 12:22, Hannes Reinecke wrote: >>>> >>>>> A linux guest will be issuing messages: >>>>> >>>>> [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 000000 bytes remain!! >>>>> [ 32.126348] DC390: DataIn_0: DMA State: 0 >>>>> >>>>> and the HBA will fail to work properly. >>>>> Reason is the emulation is not setting the 'DMA transfer done' >>>>> status correctly. >>>>> >>>>> Signed-off-by: Hannes Reinecke >>>>> --- >>>>> hw/scsi/esp-pci.c | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c >>>>> index 82795e6..77b8647 100644 >>>>> --- a/hw/scsi/esp-pci.c >>>>> +++ b/hw/scsi/esp-pci.c >>>>> @@ -268,6 +268,8 @@ static void esp_pci_dma_memory_rw(PCIESPState *pci, uint8_t *buf, int len, >>>>> /* update status registers */ >>>>> pci->dma_regs[DMA_WBC] -= len; >>>>> pci->dma_regs[DMA_WAC] += len; >>>>> + if (pci->dma_regs[DMA_WBC] == 0) >>>>> + pci->dma_regs[DMA_STAT] |= DMA_STAT_DONE; >>>>> } >>>> >>>> Missing braces on the if statement here? >>>> >>> Sigh. >>> >>> If you insist ... >>> >>> Cheers, >>> >>> Hannes >> >> That's the Qemu coding style. >> And you will fail ./script/checkpatch.pl. >> > I know. After all, it's not the first patch I've sent. > > But I always get the various codingstyle thingies > mixed up. > Hum. Each community has its own rules :) Best regards, -Gonglei