From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnm9D-0002Yi-4U for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:24:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnm97-0007sq-01 for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:24:35 -0500 Message-ID: <5460924C.7040308@redhat.com> Date: Mon, 10 Nov 2014 11:24:12 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415610638-3918-1-git-send-email-famz@redhat.com> In-Reply-To: <1415610638-3918-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Fix comment for bdrv_co_get_block_status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru, Markus Armbruster On 2014-11-10 at 10:10, Fam Zheng wrote: > It returns more information than binary, fix the comment. > > Signed-off-by: Fam Zheng > --- > block.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/block.c b/block.c > index dacd881..42c914e 100644 > --- a/block.c > +++ b/block.c > @@ -3903,9 +3903,9 @@ typedef struct BdrvCoGetBlockStatusData { > } BdrvCoGetBlockStatusData; > > /* > - * Returns true iff the specified sector is present in the disk image. Drivers > - * not implementing the functionality are assumed to not support backing files, > - * hence all their sectors are reported as allocated. > + * Returns the status of the specified sectors. Drivers not implementing the > + * functionality are assumed to not support backing files, hence all their > + * sectors are reported as allocated. > * > * If 'sector_num' is beyond the end of the disk image the return value is 0 > * and 'pnum' is set to 0. "status" is a bit broad, but pointing to "line 86 in include/block/block.h" for a further explanation will probably not be very stable. Reviewed-by: Max Reitz