From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnpnh-0007Iv-Sv for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:18:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnpnb-0003fE-OP for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:18:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnpnb-0003f0-GX for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:18:31 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAEITn3019462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 09:18:30 -0500 Message-ID: <5460C932.7020904@redhat.com> Date: Mon, 10 Nov 2014 15:18:26 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415389165-16157-1-git-send-email-kwolf@redhat.com> <1415389165-16157-2-git-send-email-kwolf@redhat.com> <5460C6AD.6070802@redhat.com> In-Reply-To: <5460C6AD.6070802@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/9] qemu-io: Allow explicitly specifying format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com On 2014-11-10 at 15:07, Max Reitz wrote: > On 2014-11-07 at 20:39, Kevin Wolf wrote: >> This adds a -f option to qemu-io which allows to explicitly specify the >> block driver to use for the given image. >> >> Signed-off-by: Kevin Wolf >> --- >> qemu-io.c | 28 ++++++++++++++++++++-------- >> 1 file changed, 20 insertions(+), 8 deletions(-) > > I would have liked the same option for the "open" command, but well. Reviewing patch 2, yes, I totally forgot about -o driver=foo. Very well then. Max > And maybe also an error if a format but no filename has been > specified, but qemu-io already does not emit an error if some other > image option has been specified, so it's fine. > > Reviewed-by: Max Reitz