From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnpqc-0001sp-0X for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:21:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnpqV-0004j0-R8 for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:21:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnpqV-0004hn-KS for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:21:31 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAELVPl028233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 09:21:31 -0500 Message-ID: <5460C9E8.7060805@redhat.com> Date: Mon, 10 Nov 2014 15:21:28 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415389165-16157-1-git-send-email-kwolf@redhat.com> <1415389165-16157-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1415389165-16157-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/9] qemu-iotests: Use qemu-io -f $IMGFMT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com On 2014-11-07 at 20:39, Kevin Wolf wrote: > This patch changes $QEMU_IO so that all tests by default pass a format > argument to qemu-io. > > There are a few cases where -f $IMGFMT is not wanted because it selects > the wrong driver or json: filenames including a driver are used. They > are changed to use $QEMU_IO_PROG, which doesn't include any options. > > Tests 071 and 081 have output changes because now the actual request > fails instead of reading the 2k probing buffer. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/016 | 11 +++++++---- > tests/qemu-iotests/048 | 2 +- > tests/qemu-iotests/058 | 11 +++++++---- > tests/qemu-iotests/071 | 10 +++++----- > tests/qemu-iotests/071.out | 6 +++--- > tests/qemu-iotests/077 | 2 +- > tests/qemu-iotests/081 | 8 ++++++-- > tests/qemu-iotests/081.out | 2 +- > tests/qemu-iotests/089 | 6 ++++-- > tests/qemu-iotests/common | 2 +- > 10 files changed, 36 insertions(+), 24 deletions(-) Reviewed-by: Max Reitz