From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnpyR-0002Je-Gx for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:29:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnpyL-0007VS-0Z for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:29:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnpyK-0007VK-Mn for qemu-devel@nongnu.org; Mon, 10 Nov 2014 09:29:36 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAETZUf001079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 09:29:35 -0500 Message-ID: <5460CBCC.4070208@redhat.com> Date: Mon, 10 Nov 2014 15:29:32 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415389165-16157-1-git-send-email-kwolf@redhat.com> <1415389165-16157-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1415389165-16157-4-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/9] qemu-iotests: Add qemu-io format option in Python tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com On 2014-11-07 at 20:39, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 22 +++++++++++----------- > tests/qemu-iotests/040 | 32 ++++++++++++++++---------------- > tests/qemu-iotests/055 | 18 +++++++++--------- > 3 files changed, 36 insertions(+), 36 deletions(-) > > diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 > index 8ce2373..952a524 100755 > --- a/tests/qemu-iotests/030 > +++ b/tests/qemu-iotests/030 > @@ -34,7 +34,7 @@ class TestSingleDrive(iotests.QMPTestCase): > iotests.create_image(backing_img, TestSingleDrive.image_len) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, mid_img) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % mid_img, test_img) > - qemu_io('-c', 'write -P 0x1 0 512', backing_img) > + qemu_io('-f', 'raw', '-c', 'write -P 0x1 0 512', backing_img) > self.vm = iotests.VM().add_drive("blkdebug::" + test_img) > self.vm.launch() > > @@ -55,8 +55,8 @@ class TestSingleDrive(iotests.QMPTestCase): > self.assert_no_active_block_jobs() > self.vm.shutdown() > > - self.assertEqual(qemu_io('-c', 'map', backing_img), > - qemu_io('-c', 'map', test_img), > + self.assertEqual(qemu_io('-f', 'raw', '-c', 'map', backing_img), > + qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img), > 'image file map does not match backing file after streaming') > > def test_stream_pause(self): > @@ -86,8 +86,8 @@ class TestSingleDrive(iotests.QMPTestCase): > self.assert_no_active_block_jobs() > self.vm.shutdown() > > - self.assertEqual(qemu_io('-c', 'map', backing_img), > - qemu_io('-c', 'map', test_img), > + self.assertEqual(qemu_io('-f', 'raw', '-c', 'map', backing_img), > + qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img), > 'image file map does not match backing file after streaming') > > def test_stream_partial(self): > @@ -101,8 +101,8 @@ class TestSingleDrive(iotests.QMPTestCase): > self.assert_no_active_block_jobs() > self.vm.shutdown() > > - self.assertEqual(qemu_io('-c', 'map', mid_img), > - qemu_io('-c', 'map', test_img), > + self.assertEqual(qemu_io('-f', iotests.imgfmt, '-c', 'map', mid_img), > + qemu_io('-f', iotests.imgfmt, '-c', 'map', test_img), > 'image file map does not match backing file after streaming') > > def test_device_not_found(self): > @@ -359,9 +359,9 @@ class TestStreamStop(iotests.QMPTestCase): > > def setUp(self): > qemu_img('create', backing_img, str(TestStreamStop.image_len)) I would have most certainly not opposed to adding -f raw here as well. > - qemu_io('-c', 'write -P 0x1 0 32M', backing_img) > + qemu_io('-f', 'raw', '-c', 'write -P 0x1 0 32M', backing_img) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, test_img) > - qemu_io('-c', 'write -P 0x1 32M 32M', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 32M 32M', test_img) > self.vm = iotests.VM().add_drive("blkdebug::" + test_img) > self.vm.launch() > > @@ -388,9 +388,9 @@ class TestSetSpeed(iotests.QMPTestCase): > > def setUp(self): > qemu_img('create', backing_img, str(TestSetSpeed.image_len)) Or here. > - qemu_io('-c', 'write -P 0x1 0 32M', backing_img) > + qemu_io('-f', 'raw', '-c', 'write -P 0x1 0 32M', backing_img) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, test_img) > - qemu_io('-c', 'write -P 0x1 32M 32M', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 32M 32M', test_img) > self.vm = iotests.VM().add_drive('blkdebug::' + test_img) > self.vm.launch() > > diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 > index 2b432ad..ea2f98e 100755 > --- a/tests/qemu-iotests/040 > +++ b/tests/qemu-iotests/040 > @@ -76,8 +76,8 @@ class TestSingleDrive(ImageCommitTestCase): > iotests.create_image(backing_img, self.image_len) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, mid_img) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % mid_img, test_img) > - qemu_io('-c', 'write -P 0xab 0 524288', backing_img) > - qemu_io('-c', 'write -P 0xef 524288 524288', mid_img) > + qemu_io('-f', 'raw', '-c', 'write -P 0xab 0 524288', backing_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288', mid_img) > self.vm = iotests.VM().add_drive(test_img) > self.vm.launch() > > @@ -89,8 +89,8 @@ class TestSingleDrive(ImageCommitTestCase): > > def test_commit(self): > self.run_commit_test(mid_img, backing_img) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > > def test_device_not_found(self): > result = self.vm.qmp('block-commit', device='nonexistent', top='%s' % mid_img) > @@ -116,13 +116,13 @@ class TestSingleDrive(ImageCommitTestCase): > > def test_top_is_active(self): > self.run_commit_test(test_img, backing_img, need_ready=True) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > > def test_top_is_default_active(self): > self.run_default_commit_test() > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', backing_img).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', backing_img).find("verification failed")) > > def test_top_and_base_reversed(self): > self.assert_no_active_block_jobs() > @@ -159,8 +159,8 @@ class TestRelativePaths(ImageCommitTestCase): > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % self.mid_img_abs, self.test_img) > qemu_img('rebase', '-u', '-b', self.backing_img, self.mid_img_abs) > qemu_img('rebase', '-u', '-b', self.mid_img, self.test_img) > - qemu_io('-c', 'write -P 0xab 0 524288', self.backing_img_abs) > - qemu_io('-c', 'write -P 0xef 524288 524288', self.mid_img_abs) > + qemu_io('-f', 'raw', '-c', 'write -P 0xab 0 524288', self.backing_img_abs) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288', self.mid_img_abs) > self.vm = iotests.VM().add_drive(self.test_img) > self.vm.launch() > > @@ -179,8 +179,8 @@ class TestRelativePaths(ImageCommitTestCase): > > def test_commit(self): > self.run_commit_test(self.mid_img, self.backing_img) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xab 0 524288', self.backing_img_abs).find("verification failed")) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xef 524288 524288', self.backing_img_abs).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', self.backing_img_abs).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', self.backing_img_abs).find("verification failed")) > > def test_device_not_found(self): > result = self.vm.qmp('block-commit', device='nonexistent', top='%s' % self.mid_img) > @@ -206,8 +206,8 @@ class TestRelativePaths(ImageCommitTestCase): > > def test_top_is_active(self): > self.run_commit_test(self.test_img, self.backing_img) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xab 0 524288', self.backing_img_abs).find("verification failed")) > - self.assertEqual(-1, qemu_io('-c', 'read -P 0xef 524288 524288', self.backing_img_abs).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xab 0 524288', self.backing_img_abs).find("verification failed")) > + self.assertEqual(-1, qemu_io('-f', 'raw', '-c', 'read -P 0xef 524288 524288', self.backing_img_abs).find("verification failed")) > > def test_top_and_base_reversed(self): > self.assert_no_active_block_jobs() > @@ -223,8 +223,8 @@ class TestSetSpeed(ImageCommitTestCase): > qemu_img('create', backing_img, str(TestSetSpeed.image_len)) Or here. > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, mid_img) > qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % mid_img, test_img) > - qemu_io('-c', 'write -P 0x1 0 512', test_img) > - qemu_io('-c', 'write -P 0xef 524288 524288', mid_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 0 512', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288', mid_img) > self.vm = iotests.VM().add_drive(test_img) > self.vm.launch() > > diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 > index 451b67d..0872444 100755 > --- a/tests/qemu-iotests/055 > +++ b/tests/qemu-iotests/055 > @@ -34,10 +34,10 @@ class TestSingleDrive(iotests.QMPTestCase): > def setUp(self): > # Write data to the image so we can compare later > qemu_img('create', '-f', iotests.imgfmt, test_img, str(TestSingleDrive.image_len)) > - qemu_io('-c', 'write -P0x5d 0 64k', test_img) > - qemu_io('-c', 'write -P0xd5 1M 32k', test_img) > - qemu_io('-c', 'write -P0xdc 32M 124k', test_img) > - qemu_io('-c', 'write -P0xdc 67043328 64k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 0 64k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xd5 1M 32k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 32M 124k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 67043328 64k', test_img) > > self.vm = iotests.VM().add_drive(test_img) > self.vm.launch() > @@ -115,7 +115,7 @@ class TestSetSpeed(iotests.QMPTestCase): > > def setUp(self): > qemu_img('create', '-f', iotests.imgfmt, test_img, str(TestSetSpeed.image_len)) > - qemu_io('-c', 'write -P1 0 512', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P1 0 512', test_img) > self.vm = iotests.VM().add_drive(test_img) > self.vm.launch() > > @@ -186,10 +186,10 @@ class TestSingleTransaction(iotests.QMPTestCase): > > def setUp(self): > qemu_img('create', '-f', iotests.imgfmt, test_img, str(TestSingleTransaction.image_len)) > - qemu_io('-c', 'write -P0x5d 0 64k', test_img) > - qemu_io('-c', 'write -P0xd5 1M 32k', test_img) > - qemu_io('-c', 'write -P0xdc 32M 124k', test_img) > - qemu_io('-c', 'write -P0xdc 67043328 64k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 0 64k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xd5 1M 32k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 32M 124k', test_img) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 67043328 64k', test_img) > > self.vm = iotests.VM().add_drive(test_img) > self.vm.launch() Reviewed-by: Max Reitz