From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnrbv-0005iG-5y for qemu-devel@nongnu.org; Mon, 10 Nov 2014 11:14:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnrbq-0008JQ-QE for qemu-devel@nongnu.org; Mon, 10 Nov 2014 11:14:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnrbq-0008JI-Gy for qemu-devel@nongnu.org; Mon, 10 Nov 2014 11:14:30 -0500 Message-ID: <5460E461.6020509@redhat.com> Date: Mon, 10 Nov 2014 09:14:25 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415598889-11244-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1415598889-11244-1-git-send-email-syeon.hwang@samsung.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ibFiSSS24Aob0emFtwN9LNdL866RRch3" Subject: Re: [Qemu-devel] [PATCH v3] error: passing a negative value to an os_errno is wrong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4ibFiSSS24Aob0emFtwN9LNdL866RRch3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/09/2014 10:54 PM, SeokYeon Hwang wrote: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. Commit message... > Fixed errno since it passes wrong value to 'error_set_errno()'. >=20 > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > +++ b/util/error.c > @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, Erro= rClass err_class, > return; > } > assert(*errp =3D=3D NULL); > + assert(os_errno >=3D 0); =2E..does not match code. (Code is correct). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4ibFiSSS24Aob0emFtwN9LNdL866RRch3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYORhAAoJEKeha0olJ0NqA3gH/RDpty1gny1oz/Lep6jm0aqe vH90UCUFyXR8KvXCZqXtuUpngWv+WAVu555g18P1Wn7apO5mzruOrI2bu2QSEu6z e/kUf5kdWuPPnSr6XHhK2o7Aoa1qRakMSw8vt/5pSDxvhqe3SiGHPwLKxhZ0x3Ij h9HWp/RZ1DpkL68B5ZaWTHaZa60yKtk8HiWq3ljBY7a0mM83rFrmrmvaApkVaP6n KYIEe6MNALMBcawC+tO4MnwwCI8nPp53/3ZoXNG3//IFMnYFi04AIBBIP8svU3UO fv/LxPJ5sEwojSqe1tnhjDB2fyIO0/FxliFHcTufSvKGX0JKINVfqFl7/2V1ka0= =kWP1 -----END PGP SIGNATURE----- --4ibFiSSS24Aob0emFtwN9LNdL866RRch3--