From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Peter Lieven <pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: Improve filename generation for blkdebug
Date: Mon, 10 Nov 2014 18:00:59 +0100 [thread overview]
Message-ID: <5460EF4B.3090803@redhat.com> (raw)
In-Reply-To: <1415638784-32311-1-git-send-email-mreitz@redhat.com>
On 2014-11-10 at 17:59, Max Reitz wrote:
> This is technically a v2 to
> "block: Fix filename generation for blkdebug and nbd" which contained a
> fix for the NBD filename generation, which has been merged into master
> by now. The rest, however, has not been yet, due to lack of reviews.
>
> Instead of pinging an old series with an already merged patch I'm
> therefore just resending the remaining two patches with this nice
> inciting cover letter which really, really makes you want to review the
> patches because they are so lovely. I don't want to say good, because I
> know my patches, but you want to review them either way because you
> can't stand the excitement to know what's in them.
>
> There is only one way of ever finding out: Review them! It'll bring
> great joy and maybe even glory!
>
>
> Also, if you don't review them and I have to send a v3, I'll attach a
> picture of a really cute kitten and tell you that this kitten will cry
> really badly if you don't adopt these patches. After another month, I
> will send a picture of a crying kitten.
>
> So you better review this version.
>
>
> git-backport-diff against v1:
>
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
>
> 001/2:[----] [--] 'blkdebug: Simplify and improve filename generation'
> 002/2:[----] [--] 'iotests: Plain blkdebug filename generation'
>
>
> Max Reitz (2):
> blkdebug: Simplify and improve filename generation
> iotests: Plain blkdebug filename generation
>
> block/blkdebug.c | 98 +++++++++++++---------------------------------
> tests/qemu-iotests/099 | 9 ++++-
> tests/qemu-iotests/099.out | 8 +++-
> 3 files changed, 41 insertions(+), 74 deletions(-)
Oops, forgot to CC Peter. I bet he can't resist yet non-existing cute
kittens.
Max
prev parent reply other threads:[~2014-11-10 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 16:59 [Qemu-devel] [PATCH v2 0/2] block: Improve filename generation for blkdebug Max Reitz
2014-11-10 16:59 ` [Qemu-devel] [PATCH v2 1/2] blkdebug: Simplify and improve filename generation Max Reitz
2014-11-10 19:15 ` Eric Blake
2014-11-11 8:01 ` Max Reitz
2014-11-10 16:59 ` [Qemu-devel] [PATCH v2 2/2] iotests: Plain blkdebug " Max Reitz
2014-11-10 19:17 ` Eric Blake
2014-11-10 17:00 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460EF4B.3090803@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).