From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnsL4-0003Ir-RP for qemu-devel@nongnu.org; Mon, 10 Nov 2014 12:01:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnsKy-0000hw-Je for qemu-devel@nongnu.org; Mon, 10 Nov 2014 12:01:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnsKy-0000hk-Bt for qemu-devel@nongnu.org; Mon, 10 Nov 2014 12:01:08 -0500 Message-ID: <5460EF4B.3090803@redhat.com> Date: Mon, 10 Nov 2014 18:00:59 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415638784-32311-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1415638784-32311-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: Improve filename generation for blkdebug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , Peter Lieven On 2014-11-10 at 17:59, Max Reitz wrote: > This is technically a v2 to > "block: Fix filename generation for blkdebug and nbd" which contained a > fix for the NBD filename generation, which has been merged into master > by now. The rest, however, has not been yet, due to lack of reviews. > > Instead of pinging an old series with an already merged patch I'm > therefore just resending the remaining two patches with this nice > inciting cover letter which really, really makes you want to review the > patches because they are so lovely. I don't want to say good, because I > know my patches, but you want to review them either way because you > can't stand the excitement to know what's in them. > > There is only one way of ever finding out: Review them! It'll bring > great joy and maybe even glory! > > > Also, if you don't review them and I have to send a v3, I'll attach a > picture of a really cute kitten and tell you that this kitten will cry > really badly if you don't adopt these patches. After another month, I > will send a picture of a crying kitten. > > So you better review this version. > > > git-backport-diff against v1: > > Key: > [----] : patches are identical > [####] : number of functional differences between upstream/downstream patch > [down] : patch is downstream-only > The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively > > 001/2:[----] [--] 'blkdebug: Simplify and improve filename generation' > 002/2:[----] [--] 'iotests: Plain blkdebug filename generation' > > > Max Reitz (2): > blkdebug: Simplify and improve filename generation > iotests: Plain blkdebug filename generation > > block/blkdebug.c | 98 +++++++++++++--------------------------------- > tests/qemu-iotests/099 | 9 ++++- > tests/qemu-iotests/099.out | 8 +++- > 3 files changed, 41 insertions(+), 74 deletions(-) Oops, forgot to CC Peter. I bet he can't resist yet non-existing cute kittens. Max