From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnv8z-00035W-Jg for qemu-devel@nongnu.org; Mon, 10 Nov 2014 15:01:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnv8u-000645-Kd for qemu-devel@nongnu.org; Mon, 10 Nov 2014 15:00:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnv8u-000641-BI for qemu-devel@nongnu.org; Mon, 10 Nov 2014 15:00:52 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAK0pdF030975 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 15:00:51 -0500 Message-ID: <54611972.5070708@redhat.com> Date: Mon, 10 Nov 2014 13:00:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415389165-16157-1-git-send-email-kwolf@redhat.com> <1415389165-16157-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1415389165-16157-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0f8IjR1mXawrbT6VuavN7Dtjx5umRF1bd" Subject: Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0f8IjR1mXawrbT6VuavN7Dtjx5umRF1bd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/07/2014 12:39 PM, Kevin Wolf wrote: > This is forbidden if the raw driver was probed. >=20 > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/109 | 100 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/109.out | 149 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 250 insertions(+) > create mode 100755 tests/qemu-iotests/109 > create mode 100644 tests/qemu-iotests/109.out Could you also add a test for writing an MBR/GRUB stage 1 sector into the image? Since that is a very common guest action on initial install of an OS into a blank disk, and also should NEVER match one of our probes (assuming we never add support for a file format that resembles an MBR master sector), it would be nice to ensure that our restrictions against writing to sector 0 only fire when actually hitting a colliding probe, and not for all writes. Likewise, maybe add a test for writing a sector of all 0 or all FF. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0f8IjR1mXawrbT6VuavN7Dtjx5umRF1bd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYRlyAAoJEKeha0olJ0Nq9bAH/RK7F6PwLtAWspRiJCIT17N5 NvvX7TEphakZ9zv5JsR9bz9eCLx9C0yQJlhnxHEwuZ/H5g6ALbp+0epNCSgNQAKK V+GCqkqLUhbg6i2YBwaeGELsnwUMokoyL/qIAzaqB1hzahcUlYvrnlJYVPO1XwPe 75dzXuLY79yVb2cRRYO+un5c/Y4m4FWW78oRw5AdeY6lUMawOvpgdcxxwh0EBE4O CDEKIbr+pp/pK8rqsukb4pgALPh+glRrj7eA7tJPWd6izLo/evNfXwMCpOGa1BX0 x0nAOzgEwRwFtK5i55sg+Q5E5cTOUEX27fwD/G8rQqJsftEe7DN/QhQKDJ4XMNw= =lheY -----END PGP SIGNATURE----- --0f8IjR1mXawrbT6VuavN7Dtjx5umRF1bd--