qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops
Date: Tue, 11 Nov 2014 08:45:23 +0800	[thread overview]
Message-ID: <54615C23.1090002@huawei.com> (raw)
In-Reply-To: <1415618126-20284-1-git-send-email-kraxel@redhat.com>

On 2014/11/10 19:15, Gerd Hoffmann wrote:

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/host-libusb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index 032a0e4..a5f9dab 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -749,13 +749,13 @@ static void usb_host_speed_compat(USBHostDevice *s)
>  
>      udev->speedmask = (1 << udev->speed);
>      if (udev->speed == USB_SPEED_SUPER && compat_high) {
> -        udev->speedmask |= USB_SPEED_HIGH;
> +        udev->speedmask |= USB_SPEED_MASK_HIGH;
>      }
>      if (udev->speed == USB_SPEED_SUPER && compat_full) {
> -        udev->speedmask |= USB_SPEED_FULL;
> +        udev->speedmask |= USB_SPEED_MASK_FULL;
>      }
>      if (udev->speed == USB_SPEED_HIGH && compat_full) {
> -        udev->speedmask |= USB_SPEED_FULL;
> +        udev->speedmask |= USB_SPEED_MASK_FULL;
>      }
>  }
>  

Nice catch. :)
Please s/tyops/typos/ in the patch's subject, and of course:

Reviewed-by: Gonglei <arei.gonglei@huawei.com>

Best regards,
-Gonglei

      reply	other threads:[~2014-11-11  0:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 11:15 [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops Gerd Hoffmann
2014-11-11  0:45 ` Gonglei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54615C23.1090002@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).