From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo9QG-00032x-UR for qemu-devel@nongnu.org; Tue, 11 Nov 2014 06:15:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xo9QA-0001Ae-2v for qemu-devel@nongnu.org; Tue, 11 Nov 2014 06:15:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo9Q9-00019w-LD for qemu-devel@nongnu.org; Tue, 11 Nov 2014 06:15:37 -0500 Message-ID: <5461EFCE.8010104@redhat.com> Date: Tue, 11 Nov 2014 12:15:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415376280-14130-1-git-send-email-drjones@redhat.com> In-Reply-To: <1415376280-14130-1-git-send-email-drjones@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones , qemu-devel@nongnu.org Cc: Peter Lieven , ehabkost@redhat.com On 07/11/2014 17:04, Andrew Jones wrote: > See individual patches. > > Andrew Jones (3): > vl: fix max_cpus check > vl: sanity check cpu topology > vl: warn on topology <-> maxcpus mismatch > > vl.c | 38 ++++++++++++++++++++++++++++++++------ > 1 file changed, 32 insertions(+), 6 deletions(-) > Looks good, but Eduardo should be the authority on this stuff. Adding Peter Lieven too, because he looked at bad -smp configurations too in the past. Paolo