* [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
@ 2014-11-11 9:23 Chen Gang
2014-11-11 10:53 ` Stefano Stabellini
2014-11-11 14:26 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 6+ messages in thread
From: Chen Gang @ 2014-11-11 9:23 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Trivial, xen-devel, qemu-devel, Stefano Stabellini
In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
xen_main_loop_prepare() directly, need not use additional variable for
it.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
xen-hvm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen-hvm.c b/xen-hvm.c
index 21f1cbb..7548794 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
static void xen_hvm_change_state_handler(void *opaque, int running,
RunState rstate)
{
- XenIOState *xstate = opaque;
if (running) {
- xen_main_loop_prepare(xstate);
+ xen_main_loop_prepare((XenIOState *)opaque);
}
}
--
1.8.5.2 (Apple Git-48)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
2014-11-11 9:23 [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate' Chen Gang
@ 2014-11-11 10:53 ` Stefano Stabellini
2014-11-11 14:24 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2014-11-11 14:26 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 1 reply; 6+ messages in thread
From: Stefano Stabellini @ 2014-11-11 10:53 UTC (permalink / raw)
To: Chen Gang
Cc: QEMU Trivial, xen-devel, Michael Tokarev, qemu-devel,
Stefano Stabellini
On Tue, 11 Nov 2014, Chen Gang wrote:
> In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> xen_main_loop_prepare() directly, need not use additional variable for
> it.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> xen-hvm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 21f1cbb..7548794 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> static void xen_hvm_change_state_handler(void *opaque, int running,
> RunState rstate)
> {
> - XenIOState *xstate = opaque;
> if (running) {
> - xen_main_loop_prepare(xstate);
> + xen_main_loop_prepare((XenIOState *)opaque);
> }
> }
>
> --
> 1.8.5.2 (Apple Git-48)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
2014-11-11 10:53 ` Stefano Stabellini
@ 2014-11-11 14:24 ` Konrad Rzeszutek Wilk
2014-11-11 14:32 ` Chen Gang
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-11-11 14:24 UTC (permalink / raw)
To: Stefano Stabellini
Cc: QEMU Trivial, xen-devel, Michael Tokarev, Chen Gang, qemu-devel
On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
> On Tue, 11 Nov 2014, Chen Gang wrote:
> > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> > xen_main_loop_prepare() directly, need not use additional variable for
> > it.
The title of your patch should say 'variable'.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> > xen-hvm.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 21f1cbb..7548794 100644
> > --- a/xen-hvm.c
> > +++ b/xen-hvm.c
> > @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> > static void xen_hvm_change_state_handler(void *opaque, int running,
> > RunState rstate)
> > {
> > - XenIOState *xstate = opaque;
> > if (running) {
> > - xen_main_loop_prepare(xstate);
> > + xen_main_loop_prepare((XenIOState *)opaque);
> > }
> > }
> >
> > --
> > 1.8.5.2 (Apple Git-48)
> >
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
2014-11-11 9:23 [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate' Chen Gang
2014-11-11 10:53 ` Stefano Stabellini
@ 2014-11-11 14:26 ` Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-11-11 14:26 UTC (permalink / raw)
To: Chen Gang; +Cc: QEMU Trivial, xen-devel, qemu-devel, Stefano Stabellini
11.11.2014 12:23, Chen Gang wrote:
> In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> xen_main_loop_prepare() directly, need not use additional variable for
> it.
gcc most likely eliminates it anyway, but heck, why not?
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
2014-11-11 14:24 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
@ 2014-11-11 14:32 ` Chen Gang
2014-11-11 14:37 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 6+ messages in thread
From: Chen Gang @ 2014-11-11 14:32 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Stefano Stabellini
Cc: QEMU Trivial, xen-devel, Michael Tokarev, qemu-devel
On 11/11/14 22:24, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
>> On Tue, 11 Nov 2014, Chen Gang wrote:
>>> In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
>>> xen_main_loop_prepare() directly, need not use additional variable for
>>> it.
>
> The title of your patch should say 'variable'.
Oh, yes, thanks. If necessary to send patch v2 for it, please let me
know.
Thanks.
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>
>>
>>> xen-hvm.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/xen-hvm.c b/xen-hvm.c
>>> index 21f1cbb..7548794 100644
>>> --- a/xen-hvm.c
>>> +++ b/xen-hvm.c
>>> @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
>>> static void xen_hvm_change_state_handler(void *opaque, int running,
>>> RunState rstate)
>>> {
>>> - XenIOState *xstate = opaque;
>>> if (running) {
>>> - xen_main_loop_prepare(xstate);
>>> + xen_main_loop_prepare((XenIOState *)opaque);
>>> }
>>> }
>>>
>>> --
>>> 1.8.5.2 (Apple Git-48)
>>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
2014-11-11 14:32 ` Chen Gang
@ 2014-11-11 14:37 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-11-11 14:37 UTC (permalink / raw)
To: Chen Gang, Konrad Rzeszutek Wilk, Stefano Stabellini
Cc: QEMU Trivial, xen-devel, qemu-devel
11.11.2014 17:32, Chen Gang wrote:
>> The title of your patch should say 'variable'.
>
> Oh, yes, thanks. If necessary to send patch v2 for it, please let me
> know.
Not only 'varialbe', but also 'redandant'. I fixed both on commit, plus
fixed grammar in commit message.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-11 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 9:23 [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate' Chen Gang
2014-11-11 10:53 ` Stefano Stabellini
2014-11-11 14:24 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2014-11-11 14:32 ` Chen Gang
2014-11-11 14:37 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-11-11 14:26 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).