From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoFpA-0001BH-1P for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:05:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoFp3-0006v6-Rp for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:05:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoFp3-0006uW-L0 for qemu-devel@nongnu.org; Tue, 11 Nov 2014 13:05:45 -0500 Message-ID: <54624FF3.2080509@redhat.com> Date: Tue, 11 Nov 2014 11:05:39 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415627159-15941-1-git-send-email-mreitz@redhat.com> <1415627159-15941-13-git-send-email-mreitz@redhat.com> In-Reply-To: <1415627159-15941-13-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rjfT0fRsR8Ag04mOHJrlrg1IqC7J4Mojr" Subject: Re: [Qemu-devel] [PATCH 12/21] qcow2: Allow creation with refcount order != 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rjfT0fRsR8Ag04mOHJrlrg1IqC7J4Mojr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a creation option to qcow2 for setting the refcount order of images= > to be created, and respect that option's value. >=20 > This breaks some test outputs, fix them. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 20 ++++++++ > include/block/block_int.h | 1 + > tests/qemu-iotests/049.out | 112 ++++++++++++++++++++++---------------= -------- > tests/qemu-iotests/079.out | 18 ++++---- > tests/qemu-iotests/082.out | 41 ++++++++++++++--- > tests/qemu-iotests/085.out | 38 +++++++-------- > 6 files changed, 139 insertions(+), 91 deletions(-) Is there any .json file that needs to be modified to allow this option to be set via QMP? I guess that can be a followup. > qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1kilobyte > -qemu-img: Invalid image size specified! You may use k, M, G, T, P or E= suffixes for=20 > +qemu-img: Invalid image size specified! You may use k, M, G, T, P or E= suffixes for > qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and ex= abytes. Nice that you are also getting rid of trailing whitespace. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rjfT0fRsR8Ag04mOHJrlrg1IqC7J4Mojr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYk/zAAoJEKeha0olJ0NqJSUH/2j5JGSxMpD4OPziYuz0tyqx 4u3zUur6DZDgePuNoMpBZDV7Vdg5nwjYR01Wf4Wz1dH8/CCP8JQnhjjqK/NgRcZ5 dUCC1XGwIl8x1ii29EW8bZNeNOjrYO1kfj3gwI1CyAZ1FxicViPYhb8I5+B5mY7C lnKWmE1dr5g8/+huN5DnEDYgJylKFU92doNI/6v1kwMatO3nqyNmgvxD4peHJ1rn kRDcuC6iU7lLw8FhYVjwHp97JfvUULAvTEh+PtLk72orqVcFsSELU6ymkBpSi4WP Ofc2MBxKZtEE5OXXAJI9h0Xb4I0/EjYH8X9esCEOAuNMkRmPJIVXa5PNaAkqqS8= =mGGO -----END PGP SIGNATURE----- --rjfT0fRsR8Ag04mOHJrlrg1IqC7J4Mojr--