From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPhV-0007pu-3C for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:38:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoPhQ-0001oy-17 for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:38:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPhP-0001op-Nk for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:38:31 -0500 Message-ID: <5462E441.1060205@redhat.com> Date: Tue, 11 Nov 2014 21:38:25 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415627159-15941-1-git-send-email-mreitz@redhat.com> <1415627159-15941-21-git-send-email-mreitz@redhat.com> In-Reply-To: <1415627159-15941-21-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4NCPvouNpWDwGwpEBNBtGxrbqXroSLdkU" Subject: Re: [Qemu-devel] [PATCH 20/21] qcow2: Point to amend function in check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4NCPvouNpWDwGwpEBNBtGxrbqXroSLdkU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2014 06:45 AM, Max Reitz wrote: > If a reference count is not representable with the current refcount > order, the image check should point to qemu-img amend for increasing th= e > refcount order. However, qemu-img amend needs write access to the image= > which cannot be provided if the image is marked corrupt; and the image > check will not mark the image consistent unless everything actually is > consistent. >=20 > Therefore, if an image is marked corrupt and the image check encounters= > a reference count overflow, it cannot be fixed by using qemu-img amend > to increase the refcount order. Instead, one has to use qemu-img conver= t > to create a completely new copy of the image in this case. >=20 > Alternatively, we may want to give the user a way of manually removing > the corrupt flag, maybe through qemu-img amend, but this is not part of= > this patch. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4NCPvouNpWDwGwpEBNBtGxrbqXroSLdkU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYuRBAAoJEKeha0olJ0NqzMUH/iDI2qyHbXA7D1Qm38Hklo7W T2HK+bF4onoyUVwPjlB2UleAGsncYhVFb0dMaEjJoyIn6SaL3Ke+kF2LMh6wjG+C yrHM72EOy4Qqm/KRW6ytZ1TnjQHPnLoin1wN+mGSV3OlCRWvBiSqDeAKph/eOdqx /n7wThCbAPGN+Fe4PCXwG6eSh5q8/0r+EwkdRYjvgMnqBhoLHg3ygg6zIoTBI6Lx GsadVWvnylcgwFZyS9PvmvRSqh2K0f8gfwHeYQ7xoCtE9m4yerZpm1slYg0PA55O xwHskrRLrhvZgO84+njegQpYFosmuKMvIPJfRaxe/T78zD/8cz3G9rG9yfmtLcA= =be09 -----END PGP SIGNATURE----- --4NCPvouNpWDwGwpEBNBtGxrbqXroSLdkU--