From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPkG-0000Vj-US for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:41:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoPkB-0002co-SB for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:41:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPkB-0002bp-JR for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:41:23 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAC4fNhZ026262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 11 Nov 2014 23:41:23 -0500 Message-ID: <5462E4F2.2030300@redhat.com> Date: Tue, 11 Nov 2014 21:41:22 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415712873-29274-1-git-send-email-mreitz@redhat.com> <1415712873-29274-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1415712873-29274-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ALgv27Tf3qoIs152RQA3IwUQpJJpaJfQa" Subject: Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ALgv27Tf3qoIs152RQA3IwUQpJJpaJfQa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2014 06:34 AM, Max Reitz wrote: > Add a command line option for adding a QMP monitor using pretty JSON > formatting. >=20 > Signed-off-by: Max Reitz > --- > qemu-options.hx | 8 ++++++++ > vl.c | 15 ++++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) >=20 Minor grammar suggestions: > diff --git a/qemu-options.hx b/qemu-options.hx > index da9851d..bc7b4c2 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2788,6 +2788,14 @@ STEXI > @findex -qmp > Like -monitor but opens in 'control' mode. > ETEXI > +DEF("qmp-pretty", HAS_ARG, QEMU_OPTION_qmp_pretty, \ > + "-qmp-pretty dev like -qmp but uses pretty JSON formatting\n", maybe s/dev like -qmp/dev: like -qmp,/ > + QEMU_ARCH_ALL) > +STEXI > +@item -qmp-pretty @var{dev} > +@findex -qmp-pretty > +Like -qmp but uses pretty JSON formatting. maybe s/-qmp/-qmp,/ Either way, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ALgv27Tf3qoIs152RQA3IwUQpJJpaJfQa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYuTyAAoJEKeha0olJ0NqFXgH+wcX6eVpV2ciN8YPwo9YwrZD JkXyYYn9c+3n1ZfWKkaYaBB7g/PTMfaRBtwqYl6M+bks4vl3ggeCFLF5NhYsRZFG o76hRL9TJBUZNwcH6GtcRS9tvLKCg9Ia7BXyba25TRkhI5ZE69h/N6D8dILs6l1u RrpNPB2xKZq1Lbj9AzaA80qdqeRh2KmJTuvLIlTf4cR9EB1cKtao8OnvFI62c5mC pMMszxSE0IDqgJB+aNFk/3fHfOLoQ1G1qvDARLwwzoUDW1U10WUWpRk1SkGXgG9m Aqitx8nNf4i8EczQnegbC6aIOLL3I1NjkFdfT0qJPwuqMJ4C35Rc9oQ0pR8adaA= =O+a0 -----END PGP SIGNATURE----- --ALgv27Tf3qoIs152RQA3IwUQpJJpaJfQa--