From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPtg-0002of-4g for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoPtb-0004sv-5d for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:51:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoPta-0004sr-T9 for qemu-devel@nongnu.org; Tue, 11 Nov 2014 23:51:07 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAC4p61g013638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 11 Nov 2014 23:51:06 -0500 Message-ID: <5462E739.9080603@redhat.com> Date: Tue, 11 Nov 2014 21:51:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1415712873-29274-1-git-send-email-mreitz@redhat.com> <1415712873-29274-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1415712873-29274-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="itE2v7fCIriPjWhinNknwUl7NPDvnxPiN" Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --itE2v7fCIriPjWhinNknwUl7NPDvnxPiN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2014 06:34 AM, Max Reitz wrote: > 067 invokes query-block, resulting in a reference output with really > long lines (which may pose a problem in email patches and always poses = a > problem when the output changes, because it is hard to see what has > actually changed). Use -qmp-pretty to mitigate this issue. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/067 | 2 +- > tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++= ++++---- > 2 files changed, 723 insertions(+), 58 deletions(-) Large, but mechanical. I'm trusting this one is correct (if the testsuite still passes, you did it right) rather than actually reading it= :) Reviewed-by: Eric Blake >=20 > diff --git a/tests/qemu-iotests/067 b/tests/qemu-iotests/067 > index d025192..29cd6b5 100755 > --- a/tests/qemu-iotests/067 > +++ b/tests/qemu-iotests/067 > @@ -39,7 +39,7 @@ _supported_os Linux > function do_run_qemu() > { > echo Testing: "$@" > - $QEMU -nographic -qmp stdio -serial none "$@" > + $QEMU -nographic -qmp-pretty stdio -serial none "$@" Such a trivial change for inducing over 700 lines of change in the expected output :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --itE2v7fCIriPjWhinNknwUl7NPDvnxPiN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUYuc5AAoJEKeha0olJ0Nq/r8H/1mqWxbxmTAmM/GUQdXJQZ37 WHJzrQXLklhAmM9r/lqOC9U6grI1Uy0N9AtfbBzgb8zhXviUfF66Uob5og6Gc4HQ rEOvrRwMNaBQ4RWwJzCYFmlctkPm0nyIJBq1a+k8uUGcYMG/RheKTrOmUERS5UOM uqLpnkZDbREsNU8elhWkmPQR7d/va9L+/Eo4Hiv7esA0CVs8FBRAYE50c33HBs4b TkgB00HCTK6R9Ym0JiONZsWYtDF5lVC1J1mgsDQ0iuS705KGopBD6FB6bIWU7JIV c8Ixc9B3ly2eWjDMKO70/885hKZdkTAWusg5AIZK+ntABjhS9JL/TJ6elC4V6Dg= =K5f1 -----END PGP SIGNATURE----- --itE2v7fCIriPjWhinNknwUl7NPDvnxPiN--