From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XoSb2-0001W9-Om
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:44:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XoSax-0005YY-PL
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:44:08 -0500
Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:65533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XoSax-0005YL-He
	for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:44:03 -0500
Received: by mail-wg0-f46.google.com with SMTP id x13so13647167wgg.5
	for <qemu-devel@nongnu.org>; Tue, 11 Nov 2014 23:44:02 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54630FBD.3010002@twiddle.net>
Date: Wed, 12 Nov 2014 08:43:57 +0100
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <3089981406285317@web29g.yandex.ru>
	<206531415709219@web10m.yandex.ru>
In-Reply-To: <206531415709219@web10m.yandex.ru>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction
 doesn't set minus sign
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Poletaev <poletaev-qemu@yandex.ru>, QEMU Developers <qemu-devel@nongnu.org>

On 11/11/2014 01:33 PM, Dmitry Poletaev wrote:
> ping
> 
> 25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
>> Obviously, there is a misprint in function implementation.
>>
>> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>>
>> ---
>>  target-i386/fpu_helper.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
>> index 1b2900d..be1e545 100644
>> --- a/target-i386/fpu_helper.c
>> +++ b/target-i386/fpu_helper.c
>> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>>      }
>>      tmp = int64_to_floatx80(val, &env->fp_status);
>>      if (cpu_ldub_data(env, ptr + 9) & 0x80) {
>> -        floatx80_chs(tmp);
>> +        tmp = floatx80_chs(tmp);
>>      }
>>      fpush(env);
>>      ST0 = tmp;

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~