* [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign
@ 2014-07-25 10:48 Dmitry Poletaev
2014-11-11 12:33 ` Dmitry Poletaev
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Poletaev @ 2014-07-25 10:48 UTC (permalink / raw)
To: QEMU Developers
Obviously, there is a misprint in function implementation.
From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
---
target-i386/fpu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
index 1b2900d..be1e545 100644
--- a/target-i386/fpu_helper.c
+++ b/target-i386/fpu_helper.c
@@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
}
tmp = int64_to_floatx80(val, &env->fp_status);
if (cpu_ldub_data(env, ptr + 9) & 0x80) {
- floatx80_chs(tmp);
+ tmp = floatx80_chs(tmp);
}
fpush(env);
ST0 = tmp;
--
1.8.4.msysgit.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign
2014-07-25 10:48 [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign Dmitry Poletaev
@ 2014-11-11 12:33 ` Dmitry Poletaev
2014-11-12 7:43 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Poletaev @ 2014-11-11 12:33 UTC (permalink / raw)
To: QEMU Developers
ping
25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
> Obviously, there is a misprint in function implementation.
>
> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>
> ---
> target-i386/fpu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
> index 1b2900d..be1e545 100644
> --- a/target-i386/fpu_helper.c
> +++ b/target-i386/fpu_helper.c
> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
> }
> tmp = int64_to_floatx80(val, &env->fp_status);
> if (cpu_ldub_data(env, ptr + 9) & 0x80) {
> - floatx80_chs(tmp);
> + tmp = floatx80_chs(tmp);
> }
> fpush(env);
> ST0 = tmp;
> --
> 1.8.4.msysgit.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign
2014-11-11 12:33 ` Dmitry Poletaev
@ 2014-11-12 7:43 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2014-11-12 7:43 UTC (permalink / raw)
To: Dmitry Poletaev, QEMU Developers
On 11/11/2014 01:33 PM, Dmitry Poletaev wrote:
> ping
>
> 25.07.2014, 15:48, "Dmitry Poletaev" <poletaev-qemu@yandex.ru>:
>> Obviously, there is a misprint in function implementation.
>>
>> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
>>
>> ---
>> target-i386/fpu_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
>> index 1b2900d..be1e545 100644
>> --- a/target-i386/fpu_helper.c
>> +++ b/target-i386/fpu_helper.c
>> @@ -622,7 +622,7 @@ void helper_fbld_ST0(CPUX86State *env, target_ulong ptr)
>> }
>> tmp = int64_to_floatx80(val, &env->fp_status);
>> if (cpu_ldub_data(env, ptr + 9) & 0x80) {
>> - floatx80_chs(tmp);
>> + tmp = floatx80_chs(tmp);
>> }
>> fpush(env);
>> ST0 = tmp;
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-12 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-25 10:48 [Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign Dmitry Poletaev
2014-11-11 12:33 ` Dmitry Poletaev
2014-11-12 7:43 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).