From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTJn-0001Sg-Fd for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoTJi-0002Z2-55 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTJh-0002Yy-Uh for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:18 -0500 Message-ID: <54631A94.4060906@redhat.com> Date: Wed, 12 Nov 2014 09:30:12 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415776088-4708-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1415776088-4708-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com On 2014-11-12 at 08:08, SeokYeon Hwang wrote: > Added 'assert(os_errno >= 0)' in 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 2ace0d8..6c9d995 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -62,6 +62,7 @@ void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, > return; > } > assert(*errp == NULL); > + assert(os_errno >= 0); > > err = g_malloc0(sizeof(*err)); > Reviewed-by: Max Reitz