From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTK7-0001dX-N2 for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoTK2-0002e7-Ub for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoTK2-0002dY-Jg for qemu-devel@nongnu.org; Wed, 12 Nov 2014 03:30:38 -0500 Message-ID: <54631AA9.1050008@redhat.com> Date: Wed, 12 Nov 2014 09:30:33 +0100 From: Max Reitz MIME-Version: 1.0 References: <1415775949-4528-1-git-send-email-syeon.hwang@samsung.com> In-Reply-To: <1415775949-4528-1-git-send-email-syeon.hwang@samsung.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: SeokYeon Hwang , qemu-devel@nongnu.org Cc: kongjianjun@gmail.com, paolo.bonzini@gmail.com, armbru@redhat.com On 2014-11-12 at 08:05, SeokYeon Hwang wrote: > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c > index 58455bd..2902f7d 100644 > --- a/hw/pci/pcie.c > +++ b/hw/pci/pcie.c > @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice *hotplug_dev, > /* the slot is electromechanically locked. > * This error is propagated up to qdev and then to HMP/QMP. > */ > - error_setg_errno(errp, -EBUSY, "slot is electromechanically locked"); > + error_setg_errno(errp, EBUSY, "slot is electromechanically locked"); > } > } Reviewed-by: Max Reitz